Skip to content

Commit 301d70a

Browse files
committed
Fix failing tests
1 parent a007e73 commit 301d70a

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

driver-core/src/main/com/mongodb/client/model/expressions/DocumentExpression.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package com.mongodb.client.model.expressions;
1818

1919
import org.bson.conversions.Bson;
20-
import org.bson.types.Decimal128;
2120

2221
import java.time.Instant;
2322

@@ -47,12 +46,8 @@ default BooleanExpression getBoolean(final String fieldName, final boolean other
4746

4847
NumberExpression getNumber(String fieldName, NumberExpression other);
4948

50-
default NumberExpression getNumber(final String fieldName, final double other) {
51-
return getNumber(fieldName, of(other));
52-
}
53-
54-
default NumberExpression getNumber(final String fieldName, final Decimal128 other) {
55-
return getNumber(fieldName, of(other));
49+
default NumberExpression getNumber(final String fieldName, final Number other) {
50+
return getNumber(fieldName, Expressions.numberToExpression(other));
5651
}
5752

5853
IntegerExpression getInteger(String fieldName);

driver-core/src/test/functional/com/mongodb/client/model/expressions/ArrayExpressionsFunctionalTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,7 @@ public void reduceMaxTest() {
206206
3,
207207
ofIntegerArray(1, 2, 3).max(of(9)),
208208
"{'$cond': [{'$eq': [{'$size': [[1, 2, 3]]}, 0]}, 9, "
209-
+ "{'$first': [{'$maxN': {'input': {'$map': {'input': {'$map': "
210-
+ "{'input': [1, 2, 3], 'in': '$$this'}}, 'in': '$$this'}}, 'n': 1}}]}]}");
209+
+ "{'$first': [{'$maxN': {'input': [1, 2, 3], 'n': 1}}]}]}");
211210
assertExpression(
212211
9,
213212
ofIntegerArray().max(of(9)));
@@ -219,8 +218,7 @@ public void reduceMinTest() {
219218
1,
220219
ofIntegerArray(1, 2, 3).min(of(9)),
221220
"{'$cond': [{'$eq': [{'$size': [[1, 2, 3]]}, 0]}, 9, "
222-
+ "{'$first': [{'$minN': {'input': {'$map': {'input': {'$map': "
223-
+ "{'input': [1, 2, 3], 'in': '$$this'}}, 'in': '$$this'}}, 'n': 1}}]}]}");
221+
+ "{'$first': [{'$minN': {'input': [1, 2, 3], 'n': 1}}]}]}");
224222
assertExpression(
225223
9,
226224
ofIntegerArray().min(of(9)));

0 commit comments

Comments
 (0)