feat(NODE-5762): include cause and package name for all MongoMissingDependencyErrors
#4067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
changed the title
cause and package name for all MongoMissingDependencyErrors
baileympearson
commented
Apr 3, 2024
nbbeeken
added
the
Primary Review
nbbeeken
suggested changes
Apr 3, 2024
nbbeeken
suggested changes
Apr 4, 2024
nbbeeken
previously approved these changes
Apr 4, 2024
addaleax
previously approved these changes
Apr 5, 2024
Co-authored-by: Anna Henningsen <[email protected]>
nbbeeken
approved these changes
Apr 5, 2024
baileympearson
added a commit
to baileympearson/node-mongodb-native
that referenced
this pull request
Apr 15, 2024
…ngDependencyError`s (mongodb#4067) Co-authored-by: Anna Henningsen <[email protected]>
This was referenced Sep 7, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
MongoMissingDependencyErrornow includes two required properties:dependencyName- the name of the missing dependencycause- the error thrown when attempting torequirethe missing dependency.Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
cause and package name included for MongoMissingDependencyErrors
MongoMissingDependencyErrors now include acauseand adependencyNamefield, which can be used to programmatically determine which package is missing and why the driver failed to load it.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript