Skip to content

Fix how we implement ?search=... filtering for multiple tags #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Pomax opened this issue Feb 20, 2020 · 1 comment
Closed

Fix how we implement ?search=... filtering for multiple tags #611

Pomax opened this issue Feb 20, 2020 · 1 comment
Assignees
@Pomax
Labels
engineering
Milestone
Mar 9

Comments

@Pomax
Copy link
Contributor

Pomax commented Feb 20, 2020

DRF changed how search=... filtering works in patch version 3.6.4, breaking backward compatibility forever. As such we need to change how we handle filtering specifically for tags, which can have multiple "matches" on a single field, something that is no longer possible.

See encode/django-rest-framework#7094 for more details.
@Pomax Pomax added this to the Mar 9 milestone Feb 20, 2020
@Pomax Pomax self-assigned this Feb 20, 2020
@Pomax Pomax mentioned this issue Feb 20, 2020
Closed
@Pomax Pomax modified the milestones: Mar 9, Feb 24 Feb 20, 2020
@cadecairos cadecairos modified the milestones: Feb 24, Mar 9 Feb 25, 2020
@Pomax
Copy link
Contributor Author

Pomax commented Feb 27, 2020

landed

@Pomax Pomax closed this as completed Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pomax Pomax

Labels
engineering
Projects
None yet
Milestone
Mar 9
Development

No branches or pull requests
2 participants
@Pomax @cadecairos