Skip to content

Deprecate all _x procedures #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
10 tasks done
martinruefenacht opened this issue Aug 19, 2021 · 6 comments
Closed
10 tasks done

Deprecate all _x procedures #518

martinruefenacht opened this issue Aug 19, 2021 · 6 comments
Assignees
Labels
chap-datatypes Datatypes Chapter Committee chap-deprecated Deprecated Functions Chapter Committee chap-ei External Interfaces Chapter Committee had reading Completed the formal proposal reading mpi-4.1 For inclusion in the MPI 4.1 standard passed final vote Passed the final formal vote passed first vote Passed the first formal vote
Milestone

Comments

@martinruefenacht
Copy link

martinruefenacht commented Aug 19, 2021

Problem

The _x procedures are replaced by the _c procedures which were introduced through the Embiggenment. Deprecating the _x procedures allows for removal in the next major version.

Proposal

Deprecate all _x procedures in the Standard.

Changes to the Text

  • MPI_Type_get_extent_x
  • MPI_Type_get_true_extent_x
  • MPI_Get_elements_x
  • MPI_Type_size_x
  • MPI_Status_set_elements_x

  • Added text about deprecation of _x procedures in the Deprecated Interfaces chapter (16).
  • Moving all _x procedure definitions to the Deprecated Interfaces chapter.
  • Replacing references to _x procedures with _c procedures since they are equivalent.
  • Add procedures to Table 2.1
  • Add Changelog entry

Impact on Implementations

None, with deprecation compliant implementations still need to implement the procedures.

Impact on Users

Deprecation has no immediate effect, anyone who uses _x procedures is strongly encouraged to swap to the corresponding _c procedure with the identical signature.

References

Previous PR was: https://github.com/mpi-forum/mpi-standard/pull/623
Fixed by: https://github.com/mpi-forum/mpi-standard/pull/829

@martinruefenacht martinruefenacht added mpi-4.1 For inclusion in the MPI 4.1 standard chap-datatypes Datatypes Chapter Committee chap-ei External Interfaces Chapter Committee chap-deprecated Deprecated Functions Chapter Committee labels Aug 19, 2021
@wesbland wesbland moved this to In Progress in MPI 4.1 Jul 5, 2022
@wesbland wesbland added this to MPI 4.1 Jul 5, 2022
@jsquyres jsquyres removed their assignment Jul 6, 2022
@Wee-Free-Scot
Copy link

@martinruefenacht is this going to be on the agenda for a reading at the Dec 22 meeting? There's one unresolved review comment (replacements exist for Fortran), but otherwise its ready. It would be a shame for this to miss the MPI-4.1 release.

@Wee-Free-Scot Wee-Free-Scot added this to the December 2022 milestone Oct 20, 2022
@wesbland wesbland removed this from the December 2022 milestone Dec 8, 2022
@wesbland
Copy link
Member

wesbland commented Dec 8, 2022

This wasn't read at the December 2022 meeting. The last opportunity for MPI 4.1 is to have it ready at the March 2022 meeting (and it needs to "pass" the reading).

@martinruefenacht Are you (or is someone else) planning to push this forward or should we move it out of the plan for MPI 4.1?

@wesbland wesbland added the scheduled reading Reading is scheduled for the next meeting label Jan 18, 2023
@wesbland wesbland added this to the February 2023 milestone Jan 18, 2023
@wesbland wesbland added the no-no label Feb 8, 2023
@wesbland wesbland moved this from In Progress to Had Reading in MPI 4.1 Feb 8, 2023
@wesbland wesbland added the had reading Completed the formal proposal reading label Feb 8, 2023
@wesbland
Copy link
Member

wesbland commented Feb 8, 2023

This passed a no-no vote on 2023-02-08.

Yes No Abstain
26 0 5

@wesbland wesbland removed the no-no label Feb 8, 2023
@RolfRabenseifner RolfRabenseifner self-assigned this Feb 16, 2023
@wesbland wesbland added the no-no label Mar 1, 2023
@wesbland wesbland modified the milestones: February 2023, March 2023 Mar 1, 2023
@wesbland wesbland added scheduled vote and removed scheduled reading Reading is scheduled for the next meeting labels Mar 1, 2023
@mpiforumbot
Copy link

This passed a no-no vote.

Yes No Abstain
31 0 0

@mpiforumbot
Copy link

This passed a 1st vote.

Yes No Abstain
30 0 1

@mpiforumbot mpiforumbot added the passed first vote Passed the first formal vote label Mar 21, 2023
@wesbland wesbland moved this from Had Reading to Passed 1st Vote in MPI 4.1 Mar 21, 2023
@wesbland wesbland modified the milestones: March 2023, May 2023 Apr 11, 2023
@wesbland wesbland added scheduled second vote Second vote is scheduled for the next meeting and removed scheduled vote labels May 3, 2023
@wesbland
Copy link
Member

wesbland commented May 3, 2023

This passed a 2nd vote.

Yes No Abstain
28 0 4

@wesbland wesbland added passed final vote Passed the final formal vote and removed scheduled second vote Second vote is scheduled for the next meeting labels May 3, 2023
@wesbland wesbland moved this from Passed 1st Vote to Passed 2nd Vote in MPI 4.1 May 3, 2023
@wgropp wgropp closed this as completed Jun 20, 2023
@github-project-automation github-project-automation bot moved this from Passed 2nd Vote to Done in MPI 4.1 Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chap-datatypes Datatypes Chapter Committee chap-deprecated Deprecated Functions Chapter Committee chap-ei External Interfaces Chapter Committee had reading Completed the formal proposal reading mpi-4.1 For inclusion in the MPI 4.1 standard passed final vote Passed the final formal vote passed first vote Passed the first formal vote
Projects
No open projects
Status: Done
Development

No branches or pull requests

8 participants