From d3d52e6ade8cb5faa3fccfdb0faa55a1e6c909e4 Mon Sep 17 00:00:00 2001 From: ycw Date: Wed, 13 Sep 2023 02:09:28 +0800 Subject: [PATCH 1/2] refactor getWorldDirection --- src/cameras/Camera.js | 6 +----- src/core/Object3D.js | 4 +--- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/cameras/Camera.js b/src/cameras/Camera.js index 85f77813157b4e..3f68b3131abf82 100644 --- a/src/cameras/Camera.js +++ b/src/cameras/Camera.js @@ -38,11 +38,7 @@ class Camera extends Object3D { getWorldDirection( target ) { - this.updateWorldMatrix( true, false ); - - const e = this.matrixWorld.elements; - - return target.set( - e[ 8 ], - e[ 9 ], - e[ 10 ] ).normalize(); + return super.getWorldDirection( target ).negate(); } diff --git a/src/core/Object3D.js b/src/core/Object3D.js index d674f668dbc3ad..3915ee7a23d9f9 100644 --- a/src/core/Object3D.js +++ b/src/core/Object3D.js @@ -511,9 +511,7 @@ class Object3D extends EventDispatcher { this.updateWorldMatrix( true, false ); - const e = this.matrixWorld.elements; - - return target.set( e[ 8 ], e[ 9 ], e[ 10 ] ).normalize(); + return target.fromArray( this.matrixWorld.elements, 8 ).normalize(); } From 940a0d2807fcacd461135678ec81a9a3359c08a7 Mon Sep 17 00:00:00 2001 From: ycw Date: Wed, 13 Sep 2023 05:17:36 +0800 Subject: [PATCH 2/2] revert object3d --- src/core/Object3D.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/core/Object3D.js b/src/core/Object3D.js index 3915ee7a23d9f9..d674f668dbc3ad 100644 --- a/src/core/Object3D.js +++ b/src/core/Object3D.js @@ -511,7 +511,9 @@ class Object3D extends EventDispatcher { this.updateWorldMatrix( true, false ); - return target.fromArray( this.matrixWorld.elements, 8 ).normalize(); + const e = this.matrixWorld.elements; + + return target.set( e[ 8 ], e[ 9 ], e[ 10 ] ).normalize(); }