[core] Batch small changes #19416
Merged
[core] Batch small changes #19416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
umbrella
Wrong commit message? |
joshwooding
reviewed
Jan 27, 2020
|
I need to fix the visual regression and I have a couple more coming.
@mbrookes It doesn't seem that we need to apply a top: 1 style.
|
oliviertassinari
force-pushed
the
batch-small-changes-v22
branch
from
5049d87 to
19c2ba9
Compare
Details of bundle changes.Comparing: 15d182c...74bc5b3
|
|
I missed it amongst all the unrelated changes. |
Until we fix CssBasline to apply body1 by default and not body2 on the body element in v5 we need to apply the style here. The smaller line height is especially concerninng.
mbrookes
previously requested changes
Jan 29, 2020
| @@ -53,7 +53,15 @@ const inHouseAds = [ | |||
| name: 'scaffoldhub', | |||
| link: 'https://scaffoldhub.io/?partner=1', | |||
| img: '/static/in-house/scaffoldhub.png', | |||
| description: '<b>ScaffoldHub</b> - Automate building your full-stack Material-UI web-app.', | |||
| description: '<b>Scaffold</b><br />Automate building your full-stack Material-UI web-app.', | |||
There was a problem hiding this comment.
Suggested change
| description: '<b>Scaffold</b><br />Automate building your full-stack Material-UI web-app.', | |
| description: '<b>ScaffoldHub</b><br />Automate building your full-stack Material-UI web-app.', |
There was a problem hiding this comment.
The logo is branded, I wanted to cover the generic noun. What do you think?
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Feb 13, 2020
This was referenced Mar 10, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.