From b04ba3740b7ca5c2c3bb02be0cc473d919c13f7e Mon Sep 17 00:00:00 2001 From: evans810 <48586010+evans810@users.noreply.github.com> Date: Mon, 19 Aug 2019 16:31:56 +0800 Subject: [PATCH 1/2] Update comment in MyBatisBatchItemWriter.java Modify comment in Line 67. As in code line 150, if assertUpdates is true, only results.size()==1 can pass the validation --- .../java/org/mybatis/spring/batch/MyBatisBatchItemWriter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/mybatis/spring/batch/MyBatisBatchItemWriter.java b/src/main/java/org/mybatis/spring/batch/MyBatisBatchItemWriter.java index f51f898522..d389d7ff76 100644 --- a/src/main/java/org/mybatis/spring/batch/MyBatisBatchItemWriter.java +++ b/src/main/java/org/mybatis/spring/batch/MyBatisBatchItemWriter.java @@ -64,7 +64,7 @@ public class MyBatisBatchItemWriter implements ItemWriter, InitializingBea private Converter itemToParameterConverter = new PassThroughConverter<>(); /** - * Public setter for the flag that determines whether an assertion is made that all items cause at least one row to be + * Public setter for the flag that determines whether an assertion is made that all items cause only one row to be * updated. * * @param assertUpdates From e03dd5f728cecac7f9a3ed7753b06c73be36500c Mon Sep 17 00:00:00 2001 From: evans810 <48586010+evans810@users.noreply.github.com> Date: Wed, 21 Aug 2019 11:19:03 +0800 Subject: [PATCH 2/2] Update comment in MyBatisBatchItemWriter.java Modify comment in Line 67. As if assertUpdates is true, only results.size() == 1 and results.get(0).getUpdateCounts()[i] != 0 can pass the validation --- .../java/org/mybatis/spring/batch/MyBatisBatchItemWriter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/mybatis/spring/batch/MyBatisBatchItemWriter.java b/src/main/java/org/mybatis/spring/batch/MyBatisBatchItemWriter.java index d389d7ff76..caf784028c 100644 --- a/src/main/java/org/mybatis/spring/batch/MyBatisBatchItemWriter.java +++ b/src/main/java/org/mybatis/spring/batch/MyBatisBatchItemWriter.java @@ -64,7 +64,7 @@ public class MyBatisBatchItemWriter implements ItemWriter, InitializingBea private Converter itemToParameterConverter = new PassThroughConverter<>(); /** - * Public setter for the flag that determines whether an assertion is made that all items cause only one row to be + * Public setter for the flag that determines whether an assertion is made that number of BatchResult objects returned is one and all items cause at least one row to be * updated. * * @param assertUpdates