Skip to content

Commit 3ae4fb6

Browse files
authored
Fix inverted noACK flag (#1321)
1 parent 67efa7a commit 3ae4fb6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

hal/transport/RFM69/driver/new/RFM69_new.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -615,7 +615,7 @@ LOCAL bool RFM69_sendWithRetry(const uint8_t recipient, const void *buffer,
615615
RFM69_DEBUG(PSTR("RFM69:SWR:SEND,TO=%" PRIu8 ",SEQ=%" PRIu16 ",RETRY=%" PRIu8 "\n"), recipient,
616616
RFM69.txSequenceNumber,retry);
617617
rfm69_controlFlags_t flags = 0u; // reset all flags
618-
RFM69_setACKRequested(flags, noACK);
618+
RFM69_setACKRequested(flags, !noACK);
619619
RFM69_setACKRSSIReport(flags, RFM69.ATCenabled);
620620
(void)RFM69_send(recipient, (uint8_t *)buffer, bufferSize, flags, !retry);
621621
if (noACK) {

hal/transport/RFM95/driver/RFM95.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ LOCAL bool RFM95_sendWithRetry(const uint8_t recipient, const void *buffer,
546546
RFM95.txSequenceNumber,
547547
retry);
548548
rfm95_controlFlags_t flags = 0u;
549-
RFM95_setACKRequested(flags, noACK);
549+
RFM95_setACKRequested(flags, !noACK);
550550
// send packet
551551
if (!RFM95_send(recipient, (uint8_t *)buffer, bufferSize, flags, !retry)) {
552552
return false;

0 commit comments

Comments
 (0)