Skip to content

Commit e6a4a0e

Browse files
committedJun 18, 2014
Fix bug of using Persistent<T>(x) rather than Persistent<T>::New(x)
1 parent d2152cf commit e6a4a0e

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed
 

‎Adapter/impl/ndb/include/ColumnProxy.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class ColumnProxy {
2727
ColumnProxy();
2828
~ColumnProxy();
2929
void setHandler(const ColumnHandler *);
30-
void setBlobBuffer(Handle<Value>);
30+
void setBlobBuffer(Handle<Object>);
3131
bool valueIsNull();
3232
BlobWriteHandler * createBlobWriteHandle(int);
3333

@@ -60,6 +60,3 @@ inline bool ColumnProxy::valueIsNull() {
6060
return isNull;
6161
}
6262

63-
inline void ColumnProxy::setBlobBuffer(Handle<Value> buffer) {
64-
blobBuffer = Persistent<Object>(buffer->ToObject());
65-
}

‎Adapter/impl/ndb/src/ColumnProxy.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,3 +74,7 @@ BlobWriteHandler * ColumnProxy::createBlobWriteHandle(int i) {
7474
}
7575
return b;
7676
}
77+
78+
void ColumnProxy::setBlobBuffer(Handle<Object> buffer) {
79+
blobBuffer = Persistent<Object>::New(buffer);
80+
}

‎Adapter/impl/ndb/src/NdbRecordObject.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,9 @@ NdbRecordObject::NdbRecordObject(const Record *_record,
5757
Handle<Value> b = blobBufferArray->ToObject()->Get(i);
5858
if(b->IsObject()) {
5959
nblobs++;
60-
assert(node::Buffer::HasInstance(b));
61-
proxy[i].setBlobBuffer(b);
60+
Handle<Object> buf = b->ToObject();
61+
assert(node::Buffer::HasInstance(buf));
62+
proxy[i].setBlobBuffer(buf);
6263
record->setNotNull(i, buffer);
6364
} else if(b->IsNull()) {
6465
record->setNull(i, buffer);

0 commit comments

Comments
 (0)
Please sign in to comment.