Fix ESLint and Spelling errors on E2E tests

This patch fixes the ESLint errors and spelling errors on all E2E tests

Change-Id: I0184ebe4e2a1f0a12771473171fc2df915230d1e

Author: Guilherme Saraiva

gui/.gitignore

@@ -45,7 +45,6 @@ frontend/src/app-wrapper/windows/.cr
 frontend/src/app-wrapper/windows/mysql-shell-gui/bin
 frontend/src/app-wrapper/windows/mysql-shell-gui/obj
 frontend/src/app-wrapper/windows/packages
-package-lock.json
 frontend/src/tests/e2e/selenium
 
 # Embedded Shell in Extension

gui/extension/cspell.json

@@ -8,17 +8,25 @@
         "charsets",
         "chromedriver",
         "codicon",
+        "countryinfo",
         "DBHOSTNAME",
         "DBPASSWORD",
         "DBPORT",
+        "DBPORTX",
+        "DBSHELLPASSWORD",
+        "DBSHELLUSERNAME",
         "DBUSERNAME",
         "Deallocate",
+        "dummyschema",
         "esnext",
         "extest",
+        "exthost",
+        "filelog",
         "flowtype",
         "IDBP",
         "informations",
         "innodb",
+        "interactable",
         "ISAM",
         "Kubuntu",
         "lightbulb",
@@ -27,11 +35,14 @@
         "mixins",
         "mutator",
         "mutators",
+        "mysqldbsystem",
         "mysqlrouter",
+        "mysqlx",
         "nchar",
         "nohide",
         "nohover",
         "nvarchar",
+        "OCID",
         "overscan",
         "pixi",
         "polyline",
@@ -55,6 +66,7 @@
         "submenu",
         "submodule",
         "subquery",
+        "syncronize",
         "tabindex",
         "TABLENAME",
         "Tablespace",
@@ -74,6 +86,7 @@
         "vsix",
         "webviews",
         "whitespaces",
+        "xpto",
         "ZEROFILL"
     ],
     "ignoreWords": [

gui/extension/tests/e2e/lib/cmdExecutor.ts

@@ -113,7 +113,7 @@ export class CommandExecutor {
             }
         }, constants.wait5seconds, "Text area was not interactable");
 
-        await driver.wait(until.elementLocated(locator.suggestWidget.exists), constants.wait150MiliSeconds)
+        await driver.wait(until.elementLocated(locator.suggestWidget.exists), constants.wait150MilliSeconds)
             .then(async () => {
                 const textArea = await driver.findElement(locator.notebook.codeEditor.textArea);
                 await textArea.sendKeys(Key.ESCAPE);
@@ -436,9 +436,9 @@ export class CommandExecutor {
     };
 
     /**
-     * Fethces the last result id that exists on the editor and updates the current object result id
+     * Fetches the last result id that exists on the editor and updates the current object result id
      */
-    public syncronizeResultId = async (): Promise<void> => {
+    public synchronizeResultId = async (): Promise<void> => {
         const lastEditorResults = await driver.wait(until
             .elementsLocated(locator.notebook.codeEditor.editor.result.exists),
             constants.wait5seconds, "Could not find any results for sync");
@@ -496,7 +496,7 @@ export class CommandExecutor {
     };
 
     /**
-     * Checks if the command is consideres as "Special". Special means the command is one of the following:
+     * Checks if the command is considered as "Special". Special means the command is one of the following:
      * - \\js
      * - \\javascript
      * - \\ts
@@ -523,7 +523,7 @@ export class CommandExecutor {
 
     /**
      * Returns the result block for an expected result id
-     * When the nextId is undefined, the method will return the last existing comand result on the editor
+     * When the nextId is undefined, the method will return the last existing command result on the editor
      * @param cmd The command
      * @param searchOnExistingId The next expected result id
      * @returns A promise resolving when the mouse cursor is placed at the desired spot
@@ -659,7 +659,7 @@ export class CommandExecutor {
 
         try {
             await driver.wait(until.elementLocated(locator.notebook.codeEditor.editor.result.hasContent),
-                constants.wait150MiliSeconds);
+                constants.wait150MilliSeconds);
         } catch (e) {
             return undefined;
         }
@@ -807,7 +807,7 @@ export class CommandExecutor {
 
     /**
      * Calculates and returns the next expected result id
-     * If the lastResultId is undefined, it will fectch the last existing result id from the editor,
+     * If the lastResultId is undefined, it will fetch the last existing result id from the editor,
      * and calculate the next one based on it
      * @param lastResultId The last known result id
      * @returns A promise resolving with the next result id

gui/extension/tests/e2e/lib/constants.ts

@@ -48,7 +48,7 @@ export const bastionUsername = process.env.OCI_BASTION_USERNAME;
 export const bastionPassword = process.env.OCI_BASTION_PASSWORD;
 
 // TIMEOUTS
-export const wait150MiliSeconds = 150;
+export const wait150MilliSeconds = 150;
 export const wait1second = 1000;
 export const wait2seconds = 2000;
 export const wait3seconds = 3000;
@@ -132,7 +132,7 @@ export const browseRESTDocs = "Browse the MySQL REST Service Documentation";
 export const configureREST = "Configure Instance for MySQL REST Service Support";
 export const setCurrentDBSchema = "Set As Current Database Schema";
 export const dumpSchemaToDisk = "Dump Schema to Disk";
-export const dumpSchemaToDiskToServ = "Dump Schema to Disk for MySQL Database Service";
+export const dumpSchemaToDiskToService = "Dump Schema to Disk for MySQL Database Service";
 export const copyToClipboard = "Copy To Clipboard";
 export const copyToClipboardName = "Name";
 export const copyToClipboardStat = "CREATE Statement";
@@ -157,7 +157,7 @@ export const killRouters = "Kill Local MySQL Router Instances";
 export const editRESTService = "Edit REST Service...";
 export const setAsCurrentREST = "Set as Current REST Service";
 export const loadRESTSchemaFromJSON = "Load REST Schema From JSON File...";
-export const exportRESTSDK = "Export REST Service SDK Files ...";
+export const exportRestSdk = "Export REST Service SDK Files ...";
 export const addNewAuthApp = "Add New Authentication App";
 export const deleteRESTService = "Delete REST Service...";
 export const mrsServiceDocs = "MRS Service Documentation";
@@ -177,8 +177,8 @@ export const setCurrentCompartment = "Set as Current Compartment";
 export const viewDBSystemInfo = "View DB System Information";
 export const createConnWithBastion = "Create Connection with Bastion Service";
 export const startDBSystem = "Start the DB System";
-export const restartDBSytem = "Restart the DB System";
-export const stopDBSytem = "Stop the DB System";
+export const restartDBSystem = "Restart the DB System";
+export const stopDBSystem = "Stop the DB System";
 export const deleteDBSystem = "Delete the DB System";
 export const createRouterEndpoint = "Create MySQL Router Endpoint on new Compute Instance";
 export const openNewShellConsole = "Open New MySQL Shell Console";
@@ -200,7 +200,7 @@ export const deleteRESTUser = "Delete User";
 
 export const checkNewTabAndWebView = "Check New Tab and WebView";
 export const checkNewTab = "Check New Tab";
-export const checkNotif = "Check Notification";
+export const checkNotification = "Check Notification";
 export const checkInput = "Check Input";
 export const checkWebViewDialog = "Check Dialog inside a webview";
 export const checkDialog = "Check Dialog";
@@ -246,7 +246,7 @@ export const dbConnectionSqliteCtxMenu = new Map([
 export const schemaCtxMenu = new Map([
     [setCurrentDBSchema, 1],
     [dumpSchemaToDisk, 2],
-    [dumpSchemaToDiskToServ, 3],
+    [dumpSchemaToDiskToService, 3],
     [copyToClipboard, 4],
     [copyToClipboardName, 0],
     [copyToClipboardStat, 1],
@@ -295,7 +295,7 @@ export const restServiceCtxMenu = new Map([
     [editRESTService, 1],
     [setAsCurrentREST, 2],
     [loadRESTSchemaFromJSON, 3],
-    [exportRESTSDK, 4],
+    [exportRestSdk, 4],
     [addNewAuthApp, 5],
     [deleteRESTService, 6],
     [mrsServiceDocs, 7],
@@ -345,8 +345,8 @@ export const ociDBSCtxMenu = new Map([
     [viewDBSystemInfo, 1],
     [createConnWithBastion, 2],
     [startDBSystem, 3],
-    [restartDBSytem, 4],
-    [stopDBSytem, 5],
+    [restartDBSystem, 4],
+    [stopDBSystem, 5],
     [deleteDBSystem, 6],
     [createRouterEndpoint, 7],
 ]);

gui/extension/tests/e2e/lib/interfaces.ts

@@ -225,7 +225,7 @@ export interface ICommandResultIdHolder {
     suite?: string;
 }
 
-export interface IExportMRSSDK {
+export interface IExportMrsSdk {
     directory: string;
     url: string;
     apiLanguage: string;

gui/extension/tests/e2e/lib/locators.ts

@@ -51,8 +51,8 @@ export const dbConnectionDialog = {
         mds: {
             profileNameList: By.id("profileNamePopup"),
             profileName: By.id("profileName"),
-            dbDystemId: By.id("mysqlDbSystemId"),
-            dbDystemName: By.id("mysqlDbSystemName"),
+            dbSystemId: By.id("mysqlDbSystemId"),
+            dbSystemName: By.id("mysqlDbSystemName"),
             bastionId: By.id("bastionId"),
             bastionName: By.id("bastionName"),
         },
@@ -201,7 +201,7 @@ export const mrsServiceDialog = {
         authCompletedUrlValidation: By.id("authCompletedUrlValidation"),
         authCompletedPageContent: By.id("authCompletedPageContent"),
     },
-    autenticationAppsTab: By.id("page3"),
+    authenticationAppsTab: By.id("page3"),
     authenticationApps: {
         vendorNameList: By.id("authApps.authVendorNamePopup"),
         vendorName: By.id("authApps.authVendorName"),
@@ -210,7 +210,7 @@ export const mrsServiceDialog = {
         authAppsId: By.id("authApps.appId"),
         authAppsAccessToken: By.id("authApps.accessToken"),
         authAppsUrl: By.id("authApps.url"),
-        authAppsurlDirectAuth: By.id("authApps.urlDirectAuth"),
+        authAppsUrlDirectAuth: By.id("authApps.urlDirectAuth"),
     },
     ok: By.id("ok"),
     cancel: By.id("cancel"),

gui/extension/tests/e2e/lib/misc.ts

@@ -93,7 +93,7 @@ export class Misc {
                 const iframe = await driver.findElements(locator.iframe.exists);
                 if (iframe.length > 0) {
                     await driver.wait(until.ableToSwitchToFrame(iframe[0]),
-                        constants.wait150MiliSeconds);
+                        constants.wait150MilliSeconds);
                 }
 
                 return true;

gui/extension/tests/e2e/lib/os.ts

@@ -89,7 +89,7 @@ export class Os {
 
     /**
      * Deletes all credentials for database access using shell
-     * @returns A promise resolving when the credetials are deleted
+     * @returns A promise resolving when the credentials are deleted
      */
     public static deleteCredentials = async (): Promise<void> => {
         const params = ["--js", "-e", "shell.deleteAllCredentials()"];
@@ -113,7 +113,7 @@ export class Os {
      * Gets the extension output logs folder
      * @returns A promise resolving with the location of the logs folder
      */
-    public static getExtentionOutputLogsFolder = async (): Promise<string> => {
+    public static getExtensionOutputLogsFolder = async (): Promise<string> => {
         let testResources: string;
         for (let i = 0; i <= process.argv.length - 1; i++) {
             if (process.argv[i] === "-s") {
@@ -168,7 +168,7 @@ export class Os {
      * @returns A promise resolving when the logs are prepared
      */
     public static prepareExtensionLogsForExport = async (testSuite: string): Promise<void> => {
-        const logPathFolder = await Os.getExtentionOutputLogsFolder();
+        const logPathFolder = await Os.getExtensionOutputLogsFolder();
         try {
             // rename the file
             await fs.rename(join(logPathFolder, constants.feLogFile),

gui/extension/tests/e2e/lib/treeViews/section.ts

@@ -159,7 +159,7 @@ export class Section {
     };
 
     /**
-     * Focus a section, by expanding the section and collapsing all the otehrs
+     * Focus a section, by expanding the section and collapsing all the others
      * @param section The section
      * @returns A promise resolving when the section is focused
      */
@@ -250,7 +250,7 @@ export class Section {
 
             }), constants.wait5seconds, `${section} was not focused`);
         } else {
-            throw new Error(`Unknow section: ${section}`);
+            throw new Error(`Unknown section: ${section}`);
         }
     };
 
@@ -294,7 +294,7 @@ export class Section {
     };
 
     /**
-     * Restarts MySQL Shell from the toolbar context mnenu
+     * Restarts MySQL Shell from the toolbar context menu
      * @returns A promise resolving when MySQL Shell is restarted
      */
     public static restartShell = async (): Promise<void> => {

gui/extension/tests/e2e/lib/treeViews/tree.ts

@@ -377,7 +377,7 @@ export class Tree {
     };
 
     /**
-     * Gets the database connections from the DABATASE CONNECTIONS section
+     * Gets the database connections from the DATABASE CONNECTIONS section
      * @returns A promise resolving with the database connections
      */
     public static getDatabaseConnections = async (): Promise<interfaces.ITreeDBConnection[]> => {

gui/extension/tests/e2e/lib/until.ts

@@ -199,13 +199,13 @@ export const toolbarButtonIsEnabled = (button: string): Condition<boolean> => {
 };
 
 export const resultTabIsMaximized = (): Condition<boolean> => {
-    return new Condition(`for result tab to be maximezed`, async () => {
+    return new Condition(`for result tab to be maximized`, async () => {
         return (await driver.findElements(locator.notebook.codeEditor.editor.result.status.normalize)).length > 0;
     });
 };
 
 export const resultTabIsNormalized = (): Condition<boolean> => {
-    return new Condition(`for result tab to be maximezed`, async () => {
+    return new Condition(`for result tab to be maximized`, async () => {
         return (await driver.findElements(locator.notebook.codeEditor.editor.result.status.normalize)).length === 0;
     });
 };
@@ -221,7 +221,7 @@ export const editorHasNewPrompt = (): Condition<boolean> => {
 
 export const notificationExists = (notification: string, dismiss = true,
     expectFailure = false): Condition<boolean> => {
-    return new Condition(`for notication '${notification}' to be displayed`, async () => {
+    return new Condition(`for notification '${notification}' to be displayed`, async () => {
         try {
             if (Misc.insideIframe) {
                 await Misc.switchBackToTopFrame();
@@ -311,7 +311,7 @@ export const extensionIsReady = (): Condition<boolean> => {
 
             const text = `Extension was not loaded successfully after ${feLoadTries} tries. Check the logs.`;
             // one last try to recover
-            const path = join(await Os.getExtentionOutputLogsFolder(), constants.feLogFile);
+            const path = join(await Os.getExtensionOutputLogsFolder(), constants.feLogFile);
             const output = (await fs.readFile(path)).toString();
             console.log("-----OUTPUT LOGS------");
             console.log(output);

gui/extension/tests/e2e/lib/webviews/dbConnection.ts

@@ -131,10 +131,10 @@ export class DatabaseConnection {
                         await driver.wait(until.elementLocated(By.id(mds.profile)), constants.wait5seconds).click();
                     }
                     if (mds.dbSystemOCID) {
-                        await DialogHelper.setFieldText(dialog, locator.dbConnectionDialog.mysql.mds.dbDystemId,
+                        await DialogHelper.setFieldText(dialog, locator.dbConnectionDialog.mysql.mds.dbSystemId,
                             mds.dbSystemOCID);
                         await dialog.click();
-                        const dbSystemName = dialog.findElement(locator.dbConnectionDialog.mysql.mds.dbDystemName);
+                        const dbSystemName = dialog.findElement(locator.dbConnectionDialog.mysql.mds.dbSystemName);
                         await driver.wait(new Condition("", async () => {
                             return !(await dbSystemName.getAttribute("value")).includes("Loading");
                         }), constants.wait10seconds, "DB System name is still loading");
@@ -223,11 +223,11 @@ export class DatabaseConnection {
      * @param schemas The schemas
      * @param opMode The operational mode
      * @param output The output
-     * @param disableCols True to disable unsupported columnds, false otherwise
-     * @param optimize True to optimze load parallelism, false otherwise
+     * @param disableCols True to disable unsupported columns, false otherwise
+     * @param optimize True to optimize load parallelism, false otherwise
      * @param enableMemory True to enable memory check, false otherwise
      * @param sqlMode The SQL mode
-     * @param exludeList The exclude list
+     * @param excludeList The exclude list
      * @returns A promise resolving when the schema data is set
      */
     public static setDataToHeatWave = async (
@@ -238,7 +238,7 @@ export class DatabaseConnection {
         optimize?: boolean,
         enableMemory?: boolean,
         sqlMode?: string,
-        exludeList?: string,
+        excludeList?: string,
     ): Promise<void> => {
 
         if (!(await Misc.insideIframe())) {
@@ -284,9 +284,9 @@ export class DatabaseConnection {
             const sqlModeInput = await dialog.findElement(locator.hwDialog.sqlMode);
             await sqlModeInput.sendKeys(sqlMode);
         }
-        if (exludeList) {
-            const exludeListInput = await dialog.findElement(locator.hwDialog.excludeList);
-            await exludeListInput.sendKeys(exludeList);
+        if (excludeList) {
+            const excludeListInput = await dialog.findElement(locator.hwDialog.excludeList);
+            await excludeListInput.sendKeys(excludeList);
         }
 
         await dialog.findElement(locator.hwDialog.ok).click();