fixes #6

Author: mysticatea

src/index.js

@@ -81,12 +81,21 @@ function defineExec() {
   return command => spawn("/bin/sh", ["-c", command]);
 }
 
+function defineKillTask() {
+  if (process.platform === "win32") {
+    return cp => { spawn("taskkill", ["/F", "/T", "/PID", cp.pid]); };
+  }
+  return cp => { cp.kill(); };
+}
+
 const exec = defineExec();
+const killTask = defineKillTask();
 
 function runTask(task, stdin, stdout, stderr) {
-  return new Promise((resolve, reject) => {
+  let cp = null;
+  const promise = new Promise((resolve, reject) => {
     // Execute.
-    const cp = exec(`npm run-script ${task}`);
+    cp = exec(`npm run-script ${task}`);
 
     // Piping stdio.
     if (stdin) { stdin.pipe(cp.stdin); }
@@ -95,15 +104,27 @@ function runTask(task, stdin, stdout, stderr) {
 
     // Register
     cp.on("exit", code => {
+      cp = null;
       if (code) {
         reject(new Error(`${task}: None-Zero Exit(${code});`));
       }
       else {
         resolve(null);
       }
     });
-    cp.on("error", reject);
+    cp.on("error", err => {
+      cp = null;
+      reject(err);
+    });
   });
+
+  promise.kill = function kill() {
+    if (cp != null) {
+      killTask(cp);
+    }
+  };
+
+  return promise;
 }
 
 //------------------------------------------------------------------------------
@@ -133,7 +154,15 @@ export default function runAll(_tasks, _options) {
   }
 
   if (parallel) {
-    return Promise.all(tasks.map(task => runTask(task, stdin, stdout, stderr)));
+    const taskPromises = tasks.map(task => runTask(task, stdin, stdout, stderr));
+    const parallelPromise = Promise.all(taskPromises);
+
+    // When one of tasks crashed, kill all tasks.
+    parallelPromise.catch(() => {
+      taskPromises.forEach(t => t.kill());
+    });
+
+    return parallelPromise;
   }
   return (function next() {
     const task = tasks.shift();

test/common.js

@@ -101,5 +101,4 @@ describe("npm-run-all", () => {
         });
       });
   });
-
 });

test/lib/util.js

@@ -22,7 +22,11 @@ exports.removeResult = function removeResult() {
   try {
     fs.unlinkSync(FILE_NAME);
   }
-  catch (err) {} //eslint-disable-line no-empty
+  catch (err) {
+    if (err.message.indexOf("ENOENT") < 0) {
+      console.error("ERROR:", err.stack);
+    }
+  }
 };
 
 
@@ -32,7 +36,13 @@ var BufferStream = exports.BufferStream = function BufferStream() {
 };
 inherits(BufferStream, Writable);
 
-BufferStream.prototype._write = function(chunk, encoding, callback) { //eslint-disable-line no-underscore-dangle
+BufferStream.prototype._write = function _write(chunk, encoding, callback) {
   this.value += chunk.toString();
   callback();
 };
+
+exports.delay = function delay(timeout) {
+  return new Promise(function(resolve) {
+    setTimeout(resolve, timeout);
+  });
+};

test/parallel.js

@@ -1,5 +1,5 @@
 import assert from "power-assert";
-import {result, removeResult} from "./lib/util";
+import {result, removeResult, delay} from "./lib/util";
 
 // Test targets.
 import runAll from "../src/index";
@@ -33,4 +33,29 @@ describe("npm-run-all", () => {
     });
   });
 
+  describe("should kill all tasks when was given --parallel option if a task exited with non-zero code:", () => {
+    it("lib version", () => {
+      return runAll(["test-task:append a", "test-task:error"], {parallel: true})
+        .then(() => delay(1500))
+        .then(
+          () => {
+            assert(false, "should fail");
+          },
+          () => {
+            assert(result() == null || result() === "a");
+          });
+    });
+
+    it("command version", () => {
+      return command(["--parallel", "test-task:append a", "test-task:error"])
+        .then(() => delay(1500))
+        .then(
+          () => {
+            assert(false, "should fail");
+          },
+          () => {
+            assert(result() == null || result() === "a");
+          });
+    });
+  });
 });