Skip to content

Commit 14f0d65

Browse files
committed
Add temporary feature flags which doesn't need change driver or testkit code (#856)
The feature flags are: * 'Temporary:CypherPathAndRelationship' * 'Temporary:DriverFetchSize' * 'Temporary:DriverMaxTxRetryTime' * 'Temporary:GetConnectionPoolMetrics'
1 parent 1cbb616 commit 14f0d65

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

packages/testkit-backend/src/request-handlers.js

+7
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,9 @@ export function NewDriver (context, data, wire) {
8181
if ('connectionAcquisitionTimeoutMs' in data) {
8282
config.connectionAcquisitionTimeout = data.connectionAcquisitionTimeoutMs
8383
}
84+
if ('fetchSize' in data) {
85+
config.fetchSize = data.fetchSize
86+
}
8487
let driver
8588
try {
8689
driver = neo4j.driver(uri, parsedAuthToken, config)
@@ -339,9 +342,13 @@ export function GetFeatures (_context, _params, wire) {
339342
'Feature:Bolt:4.4',
340343
'Feature:API:Result.List',
341344
'Temporary:ConnectionAcquisitionTimeout',
345+
'Temporary:CypherPathAndRelationship',
346+
'Temporary:DriverFetchSize',
342347
'Temporary:DriverMaxConnectionPoolSize',
348+
'Temporary:DriverMaxTxRetryTime',
343349
'Temporary:FastFailingDiscovery',
344350
'Temporary:FullSummary',
351+
'Temporary:GetConnectionPoolMetrics',
345352
'Temporary:ResultKeys',
346353
'Temporary:TransactionClose',
347354
...SUPPORTED_TLS

packages/testkit-backend/src/skipped-tests/browser.js

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ const skippedTests = [
1010
ifEquals('stub.disconnects.test_disconnects.TestDisconnects.test_fail_on_reset'),
1111
ifEquals('stub.tx_begin_parameters.test_tx_begin_parameters.TestTxBeginParameters.test_impersonation_fails_on_v4x3'),
1212
ifEquals('stub.session_run_parameters.test_session_run_parameters.TestSessionRunParameters.test_impersonation_fails_on_v4x3'),
13-
1413
),
1514
skip(
1615
'TLS Tests not implemented for browwer',

packages/testkit-backend/src/skipped-tests/common.js

+4
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ const skippedTests = [
2323
skip('Flacky because sometimes the connection is actually available',
2424
ifEndsWith('test_should_enforce_pool_size_per_cluster_member')
2525
),
26+
skip(
27+
'Flaky in TeamCity',
28+
ifEndsWith('test_should_fail_when_writing_to_unexpectedly_interrupting_writers_on_run_using_tx_function'),
29+
),
2630
skip(
2731
'Not support by the JS driver',
2832
ifEquals('neo4j.sessionrun.TestSessionRun.test_partial_iteration')

0 commit comments

Comments
 (0)