Skip to content

Commit 30b3eb3

Browse files
committed
Add temporary feature flags which doesn't need change driver or testkit code (#856)
The feature flags are: * 'Temporary:CypherPathAndRelationship' * 'Temporary:DriverFetchSize' * 'Temporary:DriverMaxTxRetryTime' * 'Temporary:GetConnectionPoolMetrics'
1 parent 4b94cbb commit 30b3eb3

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

packages/testkit-backend/src/request-handlers.js

+8
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,9 @@ export function NewDriver (context, data, wire) {
8080
if ('connectionAcquisitionTimeoutMs' in data) {
8181
config.connectionAcquisitionTimeout = data.connectionAcquisitionTimeoutMs
8282
}
83+
if ('fetchSize' in data) {
84+
config.fetchSize = data.fetchSize
85+
}
8386
let driver
8487
try {
8588
driver = neo4j.driver(uri, parsedAuthToken, config)
@@ -334,6 +337,11 @@ export function GetFeatures (_context, _params, wire) {
334337
'Feature:Bolt:4.4',
335338
'Feature:API:Result.List',
336339
'Temporary:ConnectionAcquisitionTimeout',
340+
'Temporary:TransactionClose',
341+
'Temporary:CypherPathAndRelationship',
342+
'Temporary:DriverFetchSize',
343+
'Temporary:DriverMaxTxRetryTime',
344+
'Temporary:GetConnectionPoolMetrics',
337345
...SUPPORTED_TLS
338346
]
339347
})

packages/testkit-backend/src/skipped-tests/browser.js

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ const skippedTests = [
1010
ifEquals('stub.disconnects.test_disconnects.TestDisconnects.test_fail_on_reset'),
1111
ifEquals('stub.tx_begin_parameters.test_tx_begin_parameters.TestTxBeginParameters.test_impersonation_fails_on_v4x3'),
1212
ifEquals('stub.session_run_parameters.test_session_run_parameters.TestSessionRunParameters.test_impersonation_fails_on_v4x3'),
13-
1413
),
1514
skip(
1615
'TLS Tests not implemented for browwer',

packages/testkit-backend/src/skipped-tests/common.js

+4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
import skip, { ifEquals, ifEndsWith } from './skip'
22

33
const skippedTests = [
4+
skip(
5+
'Flaky in TeamCity',
6+
ifEndsWith('test_should_fail_when_writing_to_unexpectedly_interrupting_writers_on_run_using_tx_function'),
7+
),
48
skip(
59
'Not support by the JS driver',
610
ifEquals('neo4j.sessionrun.TestSessionRun.test_partial_iteration')

0 commit comments

Comments
 (0)