Applying linter to packages/core/src

Author: bigmontz

packages/core/src/auth.ts

@@ -29,7 +29,7 @@
  */
 const auth = {
   basic: (username: string, password: string, realm?: string) => {
-    if (realm) {
+    if (realm != null) {
       return {
         scheme: 'basic',
         principal: username,
@@ -77,12 +77,12 @@ const auth = {
   }
 }
 
-function isNotEmpty<T extends object | string>(value: T | null | undefined): boolean {
+function isNotEmpty<T extends object | string> (value: T | null | undefined): boolean {
   return !(
     value === null ||
     value === undefined ||
     value === '' ||
-    Object.getPrototypeOf(value) === Object.prototype && Object.keys(value).length === 0
+    (Object.getPrototypeOf(value) === Object.prototype && Object.keys(value).length === 0)
   )
 }
 

packages/core/src/connection-provider.ts

@@ -21,7 +21,6 @@ import Connection from './connection'
 import { bookmarks } from './internal'
 import { ServerInfo } from './result-summary'
 
-
 /**
  * Inteface define a common way to acquire a connection
  *
@@ -44,11 +43,11 @@ class ConnectionProvider {
    * @property {string} param.impersonatedUser - the impersonated user
    * @property {function (databaseName:string?)} param.onDatabaseNameResolved - Callback called when the database name get resolved
    */
-  acquireConnection(param?: {
+  async acquireConnection (param?: {
     accessMode?: string
     database?: string
-    bookmarks: bookmarks.Bookmarks,
-    impersonatedUser?: string,
+    bookmarks: bookmarks.Bookmarks
+    impersonatedUser?: string
     onDatabaseNameResolved?: (databaseName?: string) => void
   }): Promise<Connection> {
     throw Error('Not implemented')
@@ -60,7 +59,7 @@ class ConnectionProvider {
    *
    * @returns {Promise<boolean>}
    */
-  supportsMultiDb(): Promise<boolean> {
+  async supportsMultiDb (): Promise<boolean> {
     throw Error('Not implemented')
   }
 
@@ -70,7 +69,7 @@ class ConnectionProvider {
    *
    * @returns {Promise<boolean>}
    */
-  supportsTransactionConfig(): Promise<boolean> {
+  async supportsTransactionConfig (): Promise<boolean> {
     throw Error('Not implemented')
   }
 
@@ -80,7 +79,7 @@ class ConnectionProvider {
    *
    * @returns {Promise<boolean>}
    */
-  supportsUserImpersonation(): Promise<boolean> {
+  async supportsUserImpersonation (): Promise<boolean> {
     throw Error('Not implemented')
   }
 
@@ -94,7 +93,7 @@ class ConnectionProvider {
    *
    * @returns {Promise<ServerInfo>} promise resolved with server info or rejected with error.
    */
-  verifyConnectivityAndGetServerInfo(param? :{ database?: string, accessMode?: string }): Promise<ServerInfo> {
+  async verifyConnectivityAndGetServerInfo (param?: { database?: string, accessMode?: string }): Promise<ServerInfo> {
     throw Error('Not implemented')
   }
 
@@ -103,7 +102,7 @@ class ConnectionProvider {
    *
    * @returns {Promise<void>}
    */
-  close(): Promise<void> {
+  async close (): Promise<void> {
     throw Error('Not implemented')
   }
 }

packages/core/src/connection.ts

@@ -25,28 +25,28 @@ import { ServerAddress } from './internal/server-address'
  */
 class Connection {
   get id (): string {
-    return ""
+    return ''
   }
 
-  get databaseId(): string {
-    return ""
+  get databaseId (): string {
+    return ''
   }
 
-  get server(): any {
+  get server (): any {
     return {}
   }
 
   /**
    * @property {ServerAddress} the server address this connection is opened against
    */
-  get address(): ServerAddress | undefined {
+  get address (): ServerAddress | undefined {
     return undefined
   }
 
   /**
    * @property {ServerVersion} the version of the server this connection is connected to
    */
-  get version(): any {
+  get version (): any {
     return undefined
   }
 
@@ -71,7 +71,7 @@ class Connection {
    * @param {Object} authToken the object containing auth information.
    * @return {Promise<Connection>} promise resolved with the current connection if connection is successful. Rejected promise otherwise.
    */
-  connect (userAgent: string, authToken: any): Promise<Connection> {
+  async connect (userAgent: string, authToken: any): Promise<Connection> {
     throw Error('Not implemented')
   }
 
@@ -89,7 +89,7 @@ class Connection {
    * Send a RESET-message to the database. Message is immediately flushed to the network.
    * @return {Promise<void>} promise resolved when SUCCESS-message response arrives, or failed when other response messages arrives.
    */
-  resetAndFlush (): Promise<void> {
+  async resetAndFlush (): Promise<void> {
     throw Error('Not implemented')
   }
 
@@ -98,15 +98,15 @@ class Connection {
    * @returns {Promise<void>} - A promise that will be resolved when the connection is closed.
    *
    */
-  close (): Promise<void> {
+  async close (): Promise<void> {
     throw Error('Not implemented')
   }
 
   /**
    * Called to release the connection
    */
-  _release (): Promise<void> {
-    return Promise.resolve()
+  async _release (): Promise<void> {
+    return await Promise.resolve()
   }
 }