Merge pull request #389 from lutovich/1.6-padStart-not-a-function

Fix 'padStart is not a function' error in NodeJS 4 and 6

Author: zhenlineo

package.json

@@ -52,13 +52,13 @@
     "gulp-util": "^3.0.6",
     "gulp-watch": "^4.3.5",
     "jasmine-console-reporter": "^2.0.1",
-    "karma": "^1.7.1",
+    "karma": "^2.0.3",
     "karma-chrome-launcher": "^2.2.0",
     "karma-edge-launcher": "^0.4.2",
-    "karma-firefox-launcher": "^1.0.1",
+    "karma-firefox-launcher": "^1.1.0",
     "karma-ie-launcher": "^1.0.0",
-    "karma-jasmine": "^1.1.0",
-    "karma-spec-reporter": "^0.0.31",
+    "karma-jasmine": "^1.1.2",
+    "karma-spec-reporter": "^0.0.32",
     "lodash": "^4.17.4",
     "lolex": "^1.5.2",
     "minimist": "^1.2.0",

src/v1/internal/temporal-util.js

@@ -383,7 +383,13 @@ function formatNumber(num, stringLength = undefined) {
   if (isNegative) {
     num = num.negate();
   }
-  const numString = num.toString();
-  const paddedNumString = stringLength ? numString.padStart(stringLength, '0') : numString;
-  return isNegative ? '-' + paddedNumString : paddedNumString;
+
+  let numString = num.toString();
+  if (stringLength) {
+    // left pad the string with zeroes
+    while (numString.length < stringLength) {
+      numString = '0' + numString;
+    }
+  }
+  return isNegative ? '-' + numString : numString;
 }

test/v1/session.test.js

@@ -291,10 +291,10 @@ describe('session', () => {
         const sum = result.summary;
         expect(sum.hasPlan()).toBe(true);
         expect(sum.hasProfile()).toBe(false);
-        expect(sum.plan.operatorType).toBe('ProduceResults');
+        expect(sum.plan.operatorType).toBeDefined();
         expect(isString(sum.plan.arguments.runtime)).toBeTruthy();
         expect(sum.plan.identifiers[0]).toBe('n');
-        expect(sum.plan.children[0].operatorType).toBe('CreateNode');
+        expect(sum.plan.children[0].operatorType).toBeDefined();
         done();
       });
   });
@@ -310,7 +310,7 @@ describe('session', () => {
         const sum = result.summary;
         expect(sum.hasPlan()).toBe(true); //When there's a profile, there's a plan
         expect(sum.hasProfile()).toBe(true);
-        expect(sum.profile.operatorType).toBe('ProduceResults');
+        expect(sum.profile.operatorType).toBeDefined();
         expect(isString(sum.profile.arguments.runtime)).toBeTruthy();
         expect(sum.profile.identifiers[0]).toBe('n');
         expect(sum.profile.children[0].operatorType).toBeDefined();