Fixes from code review

Author: pontusmelke

neo4j/v1/session.py

@@ -47,7 +47,10 @@ class AuthToken(object):
     """ Container for auth information
     """
 
-    def __init__(self, scheme, principal, credentials, realm=None, parameters=None):
+    #: By default we should not send any realm
+    realm = None
+
+    def __init__(self, scheme, principal, credentials, realm=None, **parameters):
         self.scheme = scheme
         self.principal = principal
         self.credentials = credentials
@@ -523,7 +526,7 @@ def basic_auth(user, password, realm=None):
     return AuthToken("basic", user, password, realm)
 
 
-def custom_auth(principal, credentials, realm=None, scheme=None, parameters=None):
+def custom_auth(principal, credentials, realm, scheme, **parameters):
     """ Generate a basic auth token for a given user and password.
 
     :param principal: specifies who is being authenticated
@@ -533,7 +536,7 @@ def custom_auth(principal, credentials, realm=None, scheme=None, parameters=None
     :param parameters: parameters passed along to the authenticatin provider
     :return: auth token for use with :meth:`GraphDatabase.driver`
     """
-    return AuthToken(scheme, principal, credentials, realm, parameters)
+    return AuthToken(scheme, principal, credentials, realm, **parameters)
 
 
 def run(connection, statement, parameters=None):

test/test_session.py

@@ -97,6 +97,14 @@ def test_fail_nicely_when_connecting_to_http_port(self):
         assert str(context.exception) == "Server responded HTTP. Make sure you are not trying to connect to the http " \
                                     "endpoint (HTTP defaults to port 7474 whereas BOLT defaults to port 7687)"
 
+    def test_can_provide_realm_with_basic_auth_token(self):
+        token = basic_auth("neo4j", "neo4j", "native")
+        driver = GraphDatabase.driver("bolt://localhost", auth=token)
+        session = driver.session()
+        result = session.run("RETURN 1").consume()
+        session.close()
+        assert result is not None
+
     def test_can_create_custom_auth_token(self):
         token = custom_auth("neo4j", "neo4j", "native", "basic")
         driver = GraphDatabase.driver("bolt://localhost", auth=token)
@@ -106,7 +114,7 @@ def test_can_create_custom_auth_token(self):
         assert result is not None
 
     def test_can_create_custom_auth_token_with_additional_parameters(self):
-        token = custom_auth("neo4j", "neo4j", "native", "basic", {secret: 42})
+        token = custom_auth("neo4j", "neo4j", "native", "basic", secret=42)
         driver = GraphDatabase.driver("bolt://localhost", auth=token)
         session = driver.session()
         result = session.run("RETURN 1").consume()