Skip to content

Commit f1350ad

Browse files
committed
Removed Session.__del__ and added harsh deletion test
1 parent 126060f commit f1350ad

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

neo4j/v1/session.py

-7
Original file line numberDiff line numberDiff line change
@@ -418,13 +418,6 @@ def __init__(self, driver):
418418
self.transaction = None
419419
self.last_result = None
420420

421-
def __del__(self):
422-
try:
423-
if not self.connection.closed:
424-
self.connection.close()
425-
except AttributeError:
426-
pass
427-
428421
def __enter__(self):
429422
return self
430423

test/test_session.py

+10
Original file line numberDiff line numberDiff line change
@@ -554,6 +554,16 @@ def test_can_consume_result_after_session_reuse(self):
554554
assert [record[0] for record in result_a] == [1, 2, 3]
555555
assert [record[0] for record in result_b] == [4, 5, 6]
556556

557+
def test_can_consume_results_after_harsh_session_death(self):
558+
session = self.driver.session()
559+
result_a = session.run("UNWIND range(1, 3) AS n RETURN n")
560+
del session
561+
session = self.driver.session()
562+
result_b = session.run("UNWIND range(4, 6) AS n RETURN n")
563+
del session
564+
assert [record[0] for record in result_a] == [1, 2, 3]
565+
assert [record[0] for record in result_b] == [4, 5, 6]
566+
557567
def test_can_consume_result_after_session_with_error(self):
558568
session = self.driver.session()
559569
with self.assertRaises(CypherError):

0 commit comments

Comments
 (0)