Can simultaneous request override traceId ? #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

TbotaPhantA opened this issue Jun 10, 2022 · 3 comments

TbotaPhantA commented Jun 10, 2022 •

edited

Loading

If two users will send 2 requests simultaneously:

first one will set traceId: some-uuid-1,
second one will set traceId: some-uuid-2,

then:

first one will log some-uuid-2 (but it should log some-uuid-1, becuase this is first request)
second one will log proper traceId some-uuid-2

Am I right or Am I wrong?

The text was updated successfully, but these errors were encountered:

Contributor

techvlad commented Oct 3, 2022 •

edited

Loading

No, if this corner case is possible - that's bug in Node.js core, see https://nodejs.org/api/async_context.html#class-asynclocalstorage
nodejs/node#22360

Contributor

techvlad commented Oct 3, 2022

This library is simple wrapper for AsyncLocalStorage

Author

TbotaPhantA commented Oct 3, 2022

Got it, thank you😊!

TbotaPhantA closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment