Skip to content

Modules: Fix ansible-test sanity issues #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DouglasHeriot opened this issue Apr 17, 2020 · 1 comment · Fixed by #225
Closed

Modules: Fix ansible-test sanity issues #180

DouglasHeriot opened this issue Apr 17, 2020 · 1 comment · Fixed by #225
Labels
Enhancement PR Submitted

Comments

@DouglasHeriot
Copy link
Contributor

ISSUE TYPE
  • Bug Report
Ansible:

v2.9.7

SUMMARY

ansible-test sanity has a lot of useful checks. I'm adding this to travis in #155 however will leave validate-modules disabled as there's a lot of work to do there.

STEPS TO REPRODUCE
ansible-test sanity --requirements --python 3.6 --skip-test pep8

(Skipping pep8 as it returns different errors to black, and black does a better job as it can automatically fix the issues)

EXPECTED RESULTS

No errors

ACTUAL RESULTS

See this gist for the errors: (it's a long list)
https://gist.github.com/DouglasHeriot/4d7e48430afe656b017d72dcbbb8c06d
@FragmentedPacket
Copy link
Contributor

I'll try and get these fixed over the weekend.

Thanks for all your hard work on this stuff!

@FragmentedPacket FragmentedPacket mentioned this issue Jun 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement PR Submitted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating Ansible-lint issues for validate-modules
2 participants
@DouglasHeriot @FragmentedPacket