Bug: Invalid query parameters applied to VM API

[loganbest]

ISSUE TYPE

• Bug Report

SUMMARY

When using the query_filters option and the serial filter, all virtual machines are returned due to serial not being a valid query filter (or field) for virtual machines. Netbox ignores invalid query parameters and returns all results matching the other (if any) filters.

The offending line is here:
https://github.com/netbox-community/ansible_modules/blob/devel/plugins/inventory/netbox.py#L418

Some additional parsing of query parameters is needed to remove anything invalid for virtual-machines.

Original Ansible Core Issues:
ansible/ansible#57376

@tyler-8 was the original reporter.

STEPS TO REPRODUCE

• Add device with serial number ABC1234 to Netbox
• Add VM to netbox

# netbox_inventory.yml
plugin: netbox
api_endpoint: http://localhost:8000
validate_certs: True
config_context: False
group_by:
  - device_roles
query_filters:
  - serial: ABC1234

EXPECTED RESULTS

One device returned in inventory

ACTUAL RESULTS

One device and one VM returned in inventory

[FragmentedPacket]

@tyler-8 I've implemented a fix for this. Do you mind testing this?

[tyler-8]

Thanks @FragmentedPacket - totally forgot about this. Thank you for taking the time. I'll get our team to try it out and let you know if there are any wacky side effects. Looking at the code it seems like it'll do the trick.

[FragmentedPacket]

Sounds good, Tyler. Feel free to re-open if issue is still occurring or misbhaving.