Skip to content

Commit 5caa04e

Browse files
committed
Fixes #3811: Fix filtering of racks by group on device list
1 parent f2c4906 commit 5caa04e

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

docs/release-notes/version-2.6.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
* [#3712](https://github.com/netbox-community/netbox/issues/3712) - Scrolling to target (hash) did not account for the header size
1313
* [#3780](https://github.com/netbox-community/netbox/issues/3780) - Fix AttributeError exception in API docs
1414
* [#3809](https://github.com/netbox-community/netbox/issues/3809) - Filter platform by manufacturer when editing devices
15+
* [#3811](https://github.com/netbox-community/netbox/issues/3811) - Fix filtering of racks by group on device list
1516

1617
---
1718

netbox/dcim/forms.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1729,7 +1729,7 @@ class Meta:
17291729
class DeviceFilterForm(BootstrapMixin, LocalConfigContextFilterForm, TenancyFilterForm, CustomFieldFilterForm):
17301730
model = Device
17311731
field_order = [
1732-
'q', 'region', 'site', 'rack_group_id', 'rack_id', 'status', 'role', 'tenant_group', 'tenant',
1732+
'q', 'region', 'site', 'group_id', 'rack_id', 'status', 'role', 'tenant_group', 'tenant',
17331733
'manufacturer_id', 'device_type_id', 'mac_address', 'has_primary_ip',
17341734
]
17351735
q = forms.CharField(
@@ -1755,20 +1755,20 @@ class DeviceFilterForm(BootstrapMixin, LocalConfigContextFilterForm, TenancyFilt
17551755
api_url="/api/dcim/sites/",
17561756
value_field="slug",
17571757
filter_for={
1758-
'rack_group_id': 'site',
1758+
'group_id': 'site',
17591759
'rack_id': 'site',
17601760
}
17611761
)
17621762
)
1763-
rack_group_id = FilterChoiceField(
1763+
group_id = FilterChoiceField(
17641764
queryset=RackGroup.objects.prefetch_related(
17651765
'site'
17661766
),
17671767
label='Rack group',
17681768
widget=APISelectMultiple(
17691769
api_url="/api/dcim/rack-groups/",
17701770
filter_for={
1771-
'rack_id': 'rack_group_id',
1771+
'rack_id': 'group_id',
17721772
}
17731773
)
17741774
)

0 commit comments

Comments
 (0)