Skip to content

Commit a58bbcc

Browse files
committed
Fixes #4094: Convert unnecessary regular expressions to strings in URL patterns
1 parent b1e78fa commit a58bbcc

File tree

16 files changed

+558
-558
lines changed

16 files changed

+558
-558
lines changed

netbox/circuits/api/urls.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ def get_view_name(self):
1515
router.APIRootView = CircuitsRootView
1616

1717
# Field choices
18-
router.register(r'_choices', views.CircuitsFieldChoicesViewSet, basename='field-choice')
18+
router.register('_choices', views.CircuitsFieldChoicesViewSet, basename='field-choice')
1919

2020
# Providers
21-
router.register(r'providers', views.ProviderViewSet)
21+
router.register('providers', views.ProviderViewSet)
2222

2323
# Circuits
24-
router.register(r'circuit-types', views.CircuitTypeViewSet)
25-
router.register(r'circuits', views.CircuitViewSet)
26-
router.register(r'circuit-terminations', views.CircuitTerminationViewSet)
24+
router.register('circuit-types', views.CircuitTypeViewSet)
25+
router.register('circuits', views.CircuitViewSet)
26+
router.register('circuit-terminations', views.CircuitTerminationViewSet)
2727

2828
app_name = 'circuits-api'
2929
urlpatterns = router.urls

netbox/circuits/urls.py

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -9,42 +9,42 @@
99
urlpatterns = [
1010

1111
# Providers
12-
path(r'providers/', views.ProviderListView.as_view(), name='provider_list'),
13-
path(r'providers/add/', views.ProviderCreateView.as_view(), name='provider_add'),
14-
path(r'providers/import/', views.ProviderBulkImportView.as_view(), name='provider_import'),
15-
path(r'providers/edit/', views.ProviderBulkEditView.as_view(), name='provider_bulk_edit'),
16-
path(r'providers/delete/', views.ProviderBulkDeleteView.as_view(), name='provider_bulk_delete'),
17-
path(r'providers/<slug:slug>/', views.ProviderView.as_view(), name='provider'),
18-
path(r'providers/<slug:slug>/edit/', views.ProviderEditView.as_view(), name='provider_edit'),
19-
path(r'providers/<slug:slug>/delete/', views.ProviderDeleteView.as_view(), name='provider_delete'),
20-
path(r'providers/<slug:slug>/changelog/', ObjectChangeLogView.as_view(), name='provider_changelog', kwargs={'model': Provider}),
12+
path('providers/', views.ProviderListView.as_view(), name='provider_list'),
13+
path('providers/add/', views.ProviderCreateView.as_view(), name='provider_add'),
14+
path('providers/import/', views.ProviderBulkImportView.as_view(), name='provider_import'),
15+
path('providers/edit/', views.ProviderBulkEditView.as_view(), name='provider_bulk_edit'),
16+
path('providers/delete/', views.ProviderBulkDeleteView.as_view(), name='provider_bulk_delete'),
17+
path('providers/<slug:slug>/', views.ProviderView.as_view(), name='provider'),
18+
path('providers/<slug:slug>/edit/', views.ProviderEditView.as_view(), name='provider_edit'),
19+
path('providers/<slug:slug>/delete/', views.ProviderDeleteView.as_view(), name='provider_delete'),
20+
path('providers/<slug:slug>/changelog/', ObjectChangeLogView.as_view(), name='provider_changelog', kwargs={'model': Provider}),
2121

2222
# Circuit types
23-
path(r'circuit-types/', views.CircuitTypeListView.as_view(), name='circuittype_list'),
24-
path(r'circuit-types/add/', views.CircuitTypeCreateView.as_view(), name='circuittype_add'),
25-
path(r'circuit-types/import/', views.CircuitTypeBulkImportView.as_view(), name='circuittype_import'),
26-
path(r'circuit-types/delete/', views.CircuitTypeBulkDeleteView.as_view(), name='circuittype_bulk_delete'),
27-
path(r'circuit-types/<slug:slug>/edit/', views.CircuitTypeEditView.as_view(), name='circuittype_edit'),
28-
path(r'circuit-types/<slug:slug>/changelog/', ObjectChangeLogView.as_view(), name='circuittype_changelog', kwargs={'model': CircuitType}),
23+
path('circuit-types/', views.CircuitTypeListView.as_view(), name='circuittype_list'),
24+
path('circuit-types/add/', views.CircuitTypeCreateView.as_view(), name='circuittype_add'),
25+
path('circuit-types/import/', views.CircuitTypeBulkImportView.as_view(), name='circuittype_import'),
26+
path('circuit-types/delete/', views.CircuitTypeBulkDeleteView.as_view(), name='circuittype_bulk_delete'),
27+
path('circuit-types/<slug:slug>/edit/', views.CircuitTypeEditView.as_view(), name='circuittype_edit'),
28+
path('circuit-types/<slug:slug>/changelog/', ObjectChangeLogView.as_view(), name='circuittype_changelog', kwargs={'model': CircuitType}),
2929

3030
# Circuits
31-
path(r'circuits/', views.CircuitListView.as_view(), name='circuit_list'),
32-
path(r'circuits/add/', views.CircuitCreateView.as_view(), name='circuit_add'),
33-
path(r'circuits/import/', views.CircuitBulkImportView.as_view(), name='circuit_import'),
34-
path(r'circuits/edit/', views.CircuitBulkEditView.as_view(), name='circuit_bulk_edit'),
35-
path(r'circuits/delete/', views.CircuitBulkDeleteView.as_view(), name='circuit_bulk_delete'),
36-
path(r'circuits/<int:pk>/', views.CircuitView.as_view(), name='circuit'),
37-
path(r'circuits/<int:pk>/edit/', views.CircuitEditView.as_view(), name='circuit_edit'),
38-
path(r'circuits/<int:pk>/delete/', views.CircuitDeleteView.as_view(), name='circuit_delete'),
39-
path(r'circuits/<int:pk>/changelog/', ObjectChangeLogView.as_view(), name='circuit_changelog', kwargs={'model': Circuit}),
40-
path(r'circuits/<int:pk>/terminations/swap/', views.circuit_terminations_swap, name='circuit_terminations_swap'),
31+
path('circuits/', views.CircuitListView.as_view(), name='circuit_list'),
32+
path('circuits/add/', views.CircuitCreateView.as_view(), name='circuit_add'),
33+
path('circuits/import/', views.CircuitBulkImportView.as_view(), name='circuit_import'),
34+
path('circuits/edit/', views.CircuitBulkEditView.as_view(), name='circuit_bulk_edit'),
35+
path('circuits/delete/', views.CircuitBulkDeleteView.as_view(), name='circuit_bulk_delete'),
36+
path('circuits/<int:pk>/', views.CircuitView.as_view(), name='circuit'),
37+
path('circuits/<int:pk>/edit/', views.CircuitEditView.as_view(), name='circuit_edit'),
38+
path('circuits/<int:pk>/delete/', views.CircuitDeleteView.as_view(), name='circuit_delete'),
39+
path('circuits/<int:pk>/changelog/', ObjectChangeLogView.as_view(), name='circuit_changelog', kwargs={'model': Circuit}),
40+
path('circuits/<int:pk>/terminations/swap/', views.circuit_terminations_swap, name='circuit_terminations_swap'),
4141

4242
# Circuit terminations
4343

44-
path(r'circuits/<int:circuit>/terminations/add/', views.CircuitTerminationCreateView.as_view(), name='circuittermination_add'),
45-
path(r'circuit-terminations/<int:pk>/edit/', views.CircuitTerminationEditView.as_view(), name='circuittermination_edit'),
46-
path(r'circuit-terminations/<int:pk>/delete/', views.CircuitTerminationDeleteView.as_view(), name='circuittermination_delete'),
47-
path(r'circuit-terminations/<int:termination_a_id>/connect/<str:termination_b_type>/', CableCreateView.as_view(), name='circuittermination_connect', kwargs={'termination_a_type': CircuitTermination}),
48-
path(r'circuit-terminations/<int:pk>/trace/', CableTraceView.as_view(), name='circuittermination_trace', kwargs={'model': CircuitTermination}),
44+
path('circuits/<int:circuit>/terminations/add/', views.CircuitTerminationCreateView.as_view(), name='circuittermination_add'),
45+
path('circuit-terminations/<int:pk>/edit/', views.CircuitTerminationEditView.as_view(), name='circuittermination_edit'),
46+
path('circuit-terminations/<int:pk>/delete/', views.CircuitTerminationDeleteView.as_view(), name='circuittermination_delete'),
47+
path('circuit-terminations/<int:termination_a_id>/connect/<str:termination_b_type>/', CableCreateView.as_view(), name='circuittermination_connect', kwargs={'termination_a_type': CircuitTermination}),
48+
path('circuit-terminations/<int:pk>/trace/', CableTraceView.as_view(), name='circuittermination_trace', kwargs={'model': CircuitTermination}),
4949

5050
]

netbox/dcim/api/urls.py

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -15,65 +15,65 @@ def get_view_name(self):
1515
router.APIRootView = DCIMRootView
1616

1717
# Field choices
18-
router.register(r'_choices', views.DCIMFieldChoicesViewSet, basename='field-choice')
18+
router.register('_choices', views.DCIMFieldChoicesViewSet, basename='field-choice')
1919

2020
# Sites
21-
router.register(r'regions', views.RegionViewSet)
22-
router.register(r'sites', views.SiteViewSet)
21+
router.register('regions', views.RegionViewSet)
22+
router.register('sites', views.SiteViewSet)
2323

2424
# Racks
25-
router.register(r'rack-groups', views.RackGroupViewSet)
26-
router.register(r'rack-roles', views.RackRoleViewSet)
27-
router.register(r'racks', views.RackViewSet)
28-
router.register(r'rack-reservations', views.RackReservationViewSet)
25+
router.register('rack-groups', views.RackGroupViewSet)
26+
router.register('rack-roles', views.RackRoleViewSet)
27+
router.register('racks', views.RackViewSet)
28+
router.register('rack-reservations', views.RackReservationViewSet)
2929

3030
# Device types
31-
router.register(r'manufacturers', views.ManufacturerViewSet)
32-
router.register(r'device-types', views.DeviceTypeViewSet)
31+
router.register('manufacturers', views.ManufacturerViewSet)
32+
router.register('device-types', views.DeviceTypeViewSet)
3333

3434
# Device type components
35-
router.register(r'console-port-templates', views.ConsolePortTemplateViewSet)
36-
router.register(r'console-server-port-templates', views.ConsoleServerPortTemplateViewSet)
37-
router.register(r'power-port-templates', views.PowerPortTemplateViewSet)
38-
router.register(r'power-outlet-templates', views.PowerOutletTemplateViewSet)
39-
router.register(r'interface-templates', views.InterfaceTemplateViewSet)
40-
router.register(r'front-port-templates', views.FrontPortTemplateViewSet)
41-
router.register(r'rear-port-templates', views.RearPortTemplateViewSet)
42-
router.register(r'device-bay-templates', views.DeviceBayTemplateViewSet)
35+
router.register('console-port-templates', views.ConsolePortTemplateViewSet)
36+
router.register('console-server-port-templates', views.ConsoleServerPortTemplateViewSet)
37+
router.register('power-port-templates', views.PowerPortTemplateViewSet)
38+
router.register('power-outlet-templates', views.PowerOutletTemplateViewSet)
39+
router.register('interface-templates', views.InterfaceTemplateViewSet)
40+
router.register('front-port-templates', views.FrontPortTemplateViewSet)
41+
router.register('rear-port-templates', views.RearPortTemplateViewSet)
42+
router.register('device-bay-templates', views.DeviceBayTemplateViewSet)
4343

4444
# Devices
45-
router.register(r'device-roles', views.DeviceRoleViewSet)
46-
router.register(r'platforms', views.PlatformViewSet)
47-
router.register(r'devices', views.DeviceViewSet)
45+
router.register('device-roles', views.DeviceRoleViewSet)
46+
router.register('platforms', views.PlatformViewSet)
47+
router.register('devices', views.DeviceViewSet)
4848

4949
# Device components
50-
router.register(r'console-ports', views.ConsolePortViewSet)
51-
router.register(r'console-server-ports', views.ConsoleServerPortViewSet)
52-
router.register(r'power-ports', views.PowerPortViewSet)
53-
router.register(r'power-outlets', views.PowerOutletViewSet)
54-
router.register(r'interfaces', views.InterfaceViewSet)
55-
router.register(r'front-ports', views.FrontPortViewSet)
56-
router.register(r'rear-ports', views.RearPortViewSet)
57-
router.register(r'device-bays', views.DeviceBayViewSet)
58-
router.register(r'inventory-items', views.InventoryItemViewSet)
50+
router.register('console-ports', views.ConsolePortViewSet)
51+
router.register('console-server-ports', views.ConsoleServerPortViewSet)
52+
router.register('power-ports', views.PowerPortViewSet)
53+
router.register('power-outlets', views.PowerOutletViewSet)
54+
router.register('interfaces', views.InterfaceViewSet)
55+
router.register('front-ports', views.FrontPortViewSet)
56+
router.register('rear-ports', views.RearPortViewSet)
57+
router.register('device-bays', views.DeviceBayViewSet)
58+
router.register('inventory-items', views.InventoryItemViewSet)
5959

6060
# Connections
61-
router.register(r'console-connections', views.ConsoleConnectionViewSet, basename='consoleconnections')
62-
router.register(r'power-connections', views.PowerConnectionViewSet, basename='powerconnections')
63-
router.register(r'interface-connections', views.InterfaceConnectionViewSet, basename='interfaceconnections')
61+
router.register('console-connections', views.ConsoleConnectionViewSet, basename='consoleconnections')
62+
router.register('power-connections', views.PowerConnectionViewSet, basename='powerconnections')
63+
router.register('interface-connections', views.InterfaceConnectionViewSet, basename='interfaceconnections')
6464

6565
# Cables
66-
router.register(r'cables', views.CableViewSet)
66+
router.register('cables', views.CableViewSet)
6767

6868
# Virtual chassis
69-
router.register(r'virtual-chassis', views.VirtualChassisViewSet)
69+
router.register('virtual-chassis', views.VirtualChassisViewSet)
7070

7171
# Power
72-
router.register(r'power-panels', views.PowerPanelViewSet)
73-
router.register(r'power-feeds', views.PowerFeedViewSet)
72+
router.register('power-panels', views.PowerPanelViewSet)
73+
router.register('power-feeds', views.PowerFeedViewSet)
7474

7575
# Miscellaneous
76-
router.register(r'connected-device', views.ConnectedDeviceViewSet, basename='connected-device')
76+
router.register('connected-device', views.ConnectedDeviceViewSet, basename='connected-device')
7777

7878
app_name = 'dcim-api'
7979
urlpatterns = router.urls

0 commit comments

Comments
 (0)