Skip to content

Custom link button colour(s) affected by dark mode #16238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Azmodeszer opened this issue May 22, 2024 · 7 comments · Fixed by #19290
Closed

Custom link button colour(s) affected by dark mode #16238

Azmodeszer opened this issue May 22, 2024 · 7 comments · Fixed by #19290
Assignees
@arthanson
Labels
netbox severity: low Does not significantly disrupt application functionality, or a workaround is available topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application
Milestone
v4.2.9

Comments

@Azmodeszer
Copy link
Contributor

Azmodeszer commented May 22, 2024 •
edited
Loading

Deployment Type

Self-hosted

NetBox Version

v4.0.2

Python Version

3.11

Steps to Reproduce

  1. Create a custom link with Button class "White".
  2. Enable dark mode.

Expected Behavior

Button stays white.

Observed Behavior

Button turns black.
@Azmodeszer Azmodeszer added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels May 22, 2024
@Andres1357
Copy link

Same bug with White, Gray or Black.
There's a similar issue with Default and Link class links where they become invisible in dark mode.

@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation topic: UI/UX User interface or user experience related work complexity: low Requires minimal effort to implement and removed status: needs triage This issue is awaiting triage by a maintainer labels May 29, 2024
@jeremystretch
Copy link
Member

I believe we're missing custom CSS classes for .btn-white and .btn-black.

@jeremystretch jeremystretch added severity: low Does not significantly disrupt application functionality, or a workaround is available and removed complexity: low Requires minimal effort to implement labels May 30, 2024
@ljarasius
Copy link
Contributor

I'm happy to take this one @jeremystretch

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels May 31, 2024
@arthanson
Copy link
Collaborator

@ljarasius any updates on this? Are you still able to work on this?

@ljarasius
Copy link
Contributor

@ljarasius any updates on this? Are you still able to work on this?

@arthanson sorry I haven't allocated any time as of yet to this, is this being covered under the 4.1 UI refresh or still needing investigation?

@jeremystretch
Copy link
Member

@ljarasius the v4.1 beta has been released and is available for you to test.

@ljarasius
Copy link
Contributor

@ljarasius the v4.1 beta has been released and is available for you to test.

Looks to be still an issue, will try and find some time this week to investigate further.

@jeremystretch jeremystretch added the netbox label Nov 1, 2024 — with Linear
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: accepted This issue has been accepted for implementation labels Dec 26, 2024
@arthanson arthanson self-assigned this Apr 21, 2025
@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Apr 21, 2025
@arthanson arthanson mentioned this issue Apr 23, 2025
Merged
@jeremystretch jeremystretch added this to the v4.2.9 milestone Apr 24, 2025
@jeremystretch jeremystretch mentioned this issue Apr 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthanson arthanson

Labels
netbox severity: low Does not significantly disrupt application functionality, or a workaround is available topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
v4.2.9
Development

Successfully merging a pull request may close this issue.

16238 map custom-link button colors to tabler netbox-community/netbox
6 participants
@arthanson @abhi1693 @jeremystretch @ljarasius @Andres1357 @Azmodeszer