Skip to content

Add color backgrounds for virtual circuit types #19461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aq5747 opened this issue May 10, 2025 · 2 comments · Fixed by #19484
Closed

Add color backgrounds for virtual circuit types #19461

aq5747 opened this issue May 10, 2025 · 2 comments · Fixed by #19484
Assignees
@aq5747
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone
v4.3.2

Comments

@aq5747
Copy link
Contributor

aq5747 commented May 10, 2025

NetBox version

v4.2.9

Feature type

Change to existing functionality

Proposed functionality

In v4.2.9, color backgrounds were added to circuit types in table views (#17151). However, this was not added to virtual circuit types even though those support colors as well.

This is most noticeable when viewing a provider network that has both circuits and virtual circuits assigned to it.

Image

Use case

This adds visual consistency when viewing both circuits and virtual circuits.

Database changes

None

External dependencies

None
@aq5747 aq5747 added type: feature Introduction of new functionality to the application status: needs triage This issue is awaiting triage by a maintainer labels May 10, 2025
@aq5747
Copy link
Contributor Author

aq5747 commented May 10, 2025

I'd like to contribute this if possible.

@jnovinger jnovinger added status: accepted This issue has been accepted for implementation complexity: low Requires minimal effort to implement and removed status: needs triage This issue is awaiting triage by a maintainer labels May 13, 2025
@jnovinger
Copy link
Member

It's all yours, @aq5747 !

@aq5747 aq5747 mentioned this issue May 14, 2025
Merged
@jeremystretch jeremystretch added this to the v4.3.2 milestone May 14, 2025
@jeremystretch jeremystretch mentioned this issue Jun 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aq5747 aq5747

Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v4.3.2
Development

Successfully merging a pull request may close this issue.

Closes #19461 : Add color backgrounds for virtual circuit types aq5747/netbox
3 participants
@jnovinger @jeremystretch @aq5747