Skip to content

Make webhook timestamp timezone-aware #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
psteffes opened this issue Jan 24, 2020 · 0 comments
Closed

Make webhook timestamp timezone-aware #4005

psteffes opened this issue Jan 24, 2020 · 0 comments
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@psteffes
Copy link

psteffes commented Jan 24, 2020

Environment

  • Python version: 3.7.5
  • NetBox version: 2.6.12

Proposed Functionality

My proposal is to convert the webhook "timestamp" attribute to a UTC-aware ISO 8601 string - 2020-01-24T14:22:26.976422+00:00. This can be done with the already included datetime.timezone, django.utils.timezone, or pytz.

Use Case

Timestamp can be used to ensure the correct processing order of webhooks, and the timezone-naive timestamp is ambiguous. Switching to a UTC-aware timestamp follows standard best practice around datetimes and removes any ambiguity for webhook consumers.

Database Changes

None.

External Dependencies

None.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application labels Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants