Skip to content

Comments field missing label on bulk edit #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hSaria opened this issue Jan 28, 2020 · 4 comments
Closed

Comments field missing label on bulk edit #4033

hSaria opened this issue Jan 28, 2020 · 4 comments
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@hSaria
Copy link
Contributor

hSaria commented Jan 28, 2020

Environment

  • Python version: 3.6.8
  • NetBox version: 2.7.2

Steps to Reproduce

  1. Navigate to racks list /dcim/racks/
  2. Select a rack and then click the Edit selected button

This affects bulk edit forms for Rack, Cluster, Virtual Machine, and Provider.

Expected Behavior

The comments field on the right has a label

Observed Behavior

A mysterious field appears to have no label
image

@hSaria
Copy link
Contributor Author

hSaria commented Jan 28, 2020

Just needs a quick git apply of:

diff --git a/netbox/circuits/forms.py b/netbox/circuits/forms.py
index d5d78e7..b2ccde9 100644
--- a/netbox/circuits/forms.py
+++ b/netbox/circuits/forms.py
@@ -89,7 +89,8 @@ class ProviderBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldBulkEdi
         label='Admin contact'
     )
     comments = CommentField(
-        widget=SmallTextarea()
+        widget=SmallTextarea(),
+        label='Comments'
     )
 
     class Meta:
diff --git a/netbox/dcim/forms.py b/netbox/dcim/forms.py
index e713d2c..cb301a4 100644
--- a/netbox/dcim/forms.py
+++ b/netbox/dcim/forms.py
@@ -676,7 +676,8 @@ class RackBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldBulkEditFor
         widget=StaticSelect2()
     )
     comments = CommentField(
-        widget=SmallTextarea
+        widget=SmallTextarea,
+        label='Comments'
     )
 
     class Meta:
diff --git a/netbox/virtualization/forms.py b/netbox/virtualization/forms.py
index ae516fc..ed1e5e2 100644
--- a/netbox/virtualization/forms.py
+++ b/netbox/virtualization/forms.py
@@ -171,7 +171,8 @@ class ClusterBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldBulkEdit
         )
     )
     comments = CommentField(
-        widget=SmallTextarea()
+        widget=SmallTextarea(),
+        label='Comments'
     )
 
     class Meta:
@@ -535,7 +536,8 @@ class VirtualMachineBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldB
         label='Disk (GB)'
     )
     comments = CommentField(
-        widget=SmallTextarea()
+        widget=SmallTextarea(),
+        label='Comments'
     )
 
     class Meta:

@jeremystretch
Copy link
Member

Related to #3575

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application labels Jan 28, 2020
@hSaria
Copy link
Contributor Author

hSaria commented Jan 28, 2020

And also to #713

@jeremystretch
Copy link
Member

We'll get it one day. 😆

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

2 participants