-
Notifications
You must be signed in to change notification settings - Fork 78
Allow turning off plugin status sending with CLI arg #1660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI tests are failing due to the following problem: testOpts.sendStatus
defaults to false
, so this change would prevent the createPluginRun
API request from being performed in production.
This can be fixed though by:
- Making
testOpts.sendStatus
default totrue
instead (done here). - Setting its default value to
false
in automated tests (done here). Otherwise, all automated tests would start calling thecreatePluginRun
API request, which would make them fail. - Making sure the tests related to
createPluginRun
are still passing in this new setup, since they explicitly settestOpts.sendStatus
totrue
.
Also, since this CLI flag is useful outside automated tests, would it might make sense to rename it from testOpts.sendStatus
to sendStatus
in a follow-up PR?
I'm still having trouble getting the snapshot tests to work correctly 😞. It looks like a few of the tests are no longer showing the |
It also looks like the |
1a4bd63
to
95c18ea
Compare
The second problem is due to #1684 (this just needs a code review). |
We found a solution and will implement this tomorrow:
|
This is implemented now. Should this PR be closed? |
Which problem is this pull request solving?
Allows turning off sending plugin status to API server for development.
Describe the solution you've chosen
Previously,
testOpts.sendStatus
only worked if the mode was notbuildbot
. This makes that CLI flag work regardless of whethernetlify-build
is running inbuildbot
mode.Checklist
Please add a
x
inside each checkbox: