fix: update logic for plugin selection fallback #5575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
eduardoboucas
changed the title
eduardoboucas
commented
Apr 3, 2024
| buildDir: '/some/path', | ||
| pinnedVersion: '4', | ||
|
|
||
| test('if no pinned version is set, it matches the first version regardless of whether its requirements match the conditions (legacy behavior)', async () => { |
There was a problem hiding this comment.
The diff makes it a bit hard to see (sorry), but this is one of the new tests.
There was a problem hiding this comment.
For other reviewers - https://github.com/netlify/build/pull/5575/files?w=1 (hide whitespace changes in diff) makes this diff much easier to parse
There was a problem hiding this comment.
For other reviewers - https://github.com/netlify/build/pull/5575/files?w=1 (hide whitespace changes in diff)
TIL, ty!
eduardoboucas
commented
Apr 3, 2024
| packageJson: { dependencies: { next: '14.0.0' } }, | ||
| buildDir: '/some/path', | ||
| pinnedVersion: '4', | ||
| test('if no pinned version is set, it matches the first version whose requirements match the conditions', async () => { |
There was a problem hiding this comment.
The diff makes it a bit hard to see (sorry), but this is one of the new tests.
JGAntunes
approved these changes
Apr 3, 2024
Merged
This was referenced May 23, 2024
Merged
Merged
Merged
This was referenced Jun 5, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the logic used to determine the plugin version that should be picked when there is no pinned version for the site. Includes a feature flag that toggles between just logging whenever there's a mismatch between the legacy and new logic and actually applying the new version.