fix: limit logging to authoritative plugin version

[eduardoboucas]

Summary

Adds additional system logging to the plugin version resolution logic.

[pieh]

build/packages/build/src/plugins/expected_version.ts

Lines 87 to 107 in 9b8ed35

	getExpectedVersion({
	versions,
	nodeVersion,
	packageJson,
	packageName,
	packagePath,
	buildDir,
	pinnedVersion,
	featureFlags,
	systemLog,
	}),
	getExpectedVersion({
	versions,
	nodeVersion,
	packageJson,
	packageName,
	packagePath,
	buildDir,
	featureFlags,
	systemLog,
	}),

is not setting it, so this would just mute existing log and all the ones added in this PR?

[pieh]

Just not clear to me which one of those should be authoritative one :S

[eduardoboucas]

Oops! My bad. I was passing it to the unit test and saw it working, but forgot to add it to the actual place it needs to be.

Fixed in 83dc1b2.

[eduardoboucas]

Just not clear to me which one of those should be authoritative one :S

I think it needs to be the one that sends the pinned version, which is the one that decides which version to use. Otherwise we would never take the pinned version into account.

[pieh]

Yeah -

build/packages/build/src/plugins/compatibility.ts

Lines 15 to 25 in 9b8ed35

	/**
	* Retrieve the `expectedVersion` of a plugin:
	* - This is the version which should be run
	* - This takes version pinning into account
	* - If this does not match the currently cached version, it is installed first
	* This is also used to retrieve the `compatibleVersion` of a plugin
	* - This is the most recent version compatible with this site
	* - This is the same logic except it does not use version pinning
	* - This is only used to print a warning message when the `compatibleVersion`
	* is older than the currently used version.
	*/

this also confirms it