fix: use new version of serverless functions api #5739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasholzer
force-pushed
the
fix/use-new-serverless-functions-api-and-provide-generator-variable
branch
2 times, most recently
from
251dad4 to
db0e8f7
Compare
| @@ -26,6 +26,15 @@ export interface EntryFile { | |||
| filename: string | |||
| } | |||
|
|
|||
| export const kebabCase = (input: string): string => | |||
There was a problem hiding this comment.
Why do we have to use kebab case for the service name? Is that important enough that warrants shipping our own implementation of a kebab case transformer?
There was a problem hiding this comment.
yes, because Datadog has a special naming convention. Even @ signs, which are common in the generator, should not occur.
| let serviceVersion: string | undefined | ||
|
|
||
| if (generator) { | ||
| const parts = generator.split('@') |
There was a problem hiding this comment.
Can we add a comment explaining what's going on here?
There was a problem hiding this comment.
There's nothing forcing generator to include a version, so what if is something like @org/package? This logic will make serviceVersion contain org/package, which is not what we want?
lukasholzer
force-pushed
the
fix/use-new-serverless-functions-api-and-provide-generator-variable
branch
from
db0e8f7 to
f11fc4e
Compare
Merged
provide the service name and version as variables to it.
lukasholzer
force-pushed
the
fix/use-new-serverless-functions-api-and-provide-generator-variable
branch
from
f11fc4e to
a6c39fc
Compare
eduardoboucas
approved these changes
Jun 25, 2024
…vide-generator-variable
lukasholzer
deleted the
fix/use-new-serverless-functions-api-and-provide-generator-variable
branch
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes https://linear.app/netlify/issue/COM-684/trace-resource-name-and-trace-attributes
Fixes https://linear.app/netlify/issue/COM-806/change-service-name-for-nextjs-server-handler
provide the service name and version as variables to it.
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)