Skip to content

fix: accept string literal keys in in-source config #5745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: accept string literal keys in in-source config #5745

merged 1 commit into from
Jun 27, 2024

Conversation

eduardoboucas
Copy link
Member

Summary

Currently, this works in a function:

export const config = {
  path: "/foo"
}

... but this doesn't:

export const config = {
  "path": "/foo"
}

This PR fixes that.

@eduardoboucas eduardoboucas requested review from a team as code owners June 27, 2024 18:35
serhalp
serhalp approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eduardoboucas eduardoboucas merged commit a42897e into main Jun 27, 2024
@eduardoboucas eduardoboucas deleted the fix/isc-string-literal branch June 27, 2024 20:03
This was referenced Jun 27, 2024
Merged
Merged
@eduardoboucas eduardoboucas mentioned this pull request Jul 1, 2024
Merged
@netlify-circleci netlify-circleci mentioned this pull request Jul 22, 2024
Merged
@netlify-circleci netlify-circleci mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhalp serhalp serhalp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardoboucas @serhalp