feat: framework detection for tanstack router and tanstack start #5857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the new 2 entries will need to be added here https://github.com/netlify/build/blob/main/packages/build-info/src/frameworks/index.ts |
serhalp
reviewed
Sep 27, 2024
|
serhalp
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding framework detection for TanStack Router and TanStack Start. The former works with Vite to produce a client bundle in the
distfolder. The latter works with Vite and Vinxi to produce client and server bundles.I can only find PNG images for now but Tanner is aware and will be supplying SVG images.