Skip to content

fix: ensure we pass an ArrayBuffer to blobStore.set and not a NodeJS Buffer #5927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 10, 2024
Merged

fix: ensure we pass an ArrayBuffer to blobStore.set and not a NodeJS Buffer #5927

merged 4 commits into from
Dec 10, 2024

Conversation

JakeChampion
Copy link
Contributor

This should fix the failing CI builds we have when installing the dependencies without the package-lock

@mrstork mrstork mentioned this pull request Dec 6, 2024
Closed
5 tasks
mrstork
mrstork previously approved these changes Dec 6, 2024
View reviewed changes
@JakeChampion JakeChampion marked this pull request as ready for review December 6, 2024 15:56
@JakeChampion JakeChampion requested a review from a team as a code owner December 6, 2024 15:56
mrstork
mrstork reviewed Dec 6, 2024
View reviewed changes
@JakeChampion JakeChampion requested a review from mrstork December 6, 2024 18:21
@JakeChampion JakeChampion requested a review from serhalp December 6, 2024 18:32
YujohnNattrass
YujohnNattrass previously approved these changes Dec 6, 2024
View reviewed changes
YujohnNattrass
YujohnNattrass previously approved these changes Dec 8, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files. Consider converting them to TypeScript.
Thank you for converting JavaScript files to TypeScript 🎉"

serhalp
serhalp reviewed Dec 10, 2024
View reviewed changes
serhalp
serhalp reviewed Dec 10, 2024
View reviewed changes
serhalp
serhalp reviewed Dec 10, 2024
View reviewed changes
@serhalp
Copy link
Member

serhalp commented Dec 10, 2024

See also #5932 — a completely unrelated CI issue recently introduced as well

@serhalp serhalp enabled auto-merge (squash) December 10, 2024 18:10
@serhalp serhalp removed the request for review from mrstork December 10, 2024 18:16
@serhalp serhalp merged commit ebfc770 into main Dec 10, 2024
38 checks passed
@serhalp serhalp deleted the jake/ts branch December 10, 2024 18:52
@netlify-circleci netlify-circleci mentioned this pull request Dec 10, 2024
Merged
@netlify-circleci netlify-circleci mentioned this pull request Mar 18, 2025
Closed
@netlify-circleci netlify-circleci mentioned this pull request May 13, 2025
Merged
@netlify-circleci netlify-circleci mentioned this pull request Jul 11, 2025
Closed
@netlify-circleci netlify-circleci mentioned this pull request Jul 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh left review comments

@mrstork mrstork mrstork left review comments

@serhalp serhalp serhalp approved these changes

+1 more reviewer

@YujohnNattrass YujohnNattrass YujohnNattrass left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JakeChampion @serhalp @pieh @mrstork @YujohnNattrass