fix: only log auto install extension errors with debug flag #6436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up error logging in auto-install extensions
Problem
The auto-install extensions feature had verbose error logging that would show confusing error messages to users during normal
netlify dev
usage. The error handling code was also repetitive and lengthy. This is caused by resolve config running in the cli base command and working correctly, but when the dev command callsstartDev
frombuild
, it is not populating the same config values that auto install extension handler expects.I also added a try catch to the
fetchAutoInstallableExtensionsMeta
to gracefully fail and return an empty array if the request fails for whatever reason.Solution
debug
flag is enabledChanges
debug
parameter toAutoInstallOptions
interface andhandleAutoInstallExtensions
functiondebug
flagdebug
flag from main config resolution to auto-install functionFor us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)