feat: add header to installing extension with the build mode so we know where the installation is coming from #6478
Conversation
…ow where the installation is coming from
| }), | ||
| headers: { | ||
| 'netlify-token': netlifyToken, | ||
| 'User-Agent': extensionInstallSource, |
There was a problem hiding this comment.
So the user agent will be 'buildbot' | 'cli' | 'require'? For future-proofness, do we want to be a bit more descriptive and include the fact that we're calling from Netlify Build, potentially including the version?
There was a problem hiding this comment.
hmm yeah, it's not always netlify build though, could be the call to netlify config they do (we still have the double call thing)
There was a problem hiding this comment.
I'd suggest something like:
User-Agent: Netlify Build (mode:${extensionInstallationSource}) / ${buildVersion}
If there's any other arbitrary metadata that might be useful to us later in analysis, we can include it semicolon-delimited in the parenthetical.
khendrikse
force-pushed
the
ex-114/add-extension-install-source-header
branch
from
50fa538 to
7132701
Compare
| import { ModeOption } from '../../types/options.js' | ||
| import { ROOT_PACKAGE_JSON } from '../json.js' | ||
|
|
||
| const configVersion = ROOT_PACKAGE_JSON.version |
There was a problem hiding this comment.
nit: This variable feels unnecessary.
| "description": "Netlify config module", | ||
| "type": "module", | ||
| "exports": "./lib/index.js", | ||
| "exports": { |
There was a problem hiding this comment.
Did you mean to keep this change?
3 participants
🎉 Thanks for submitting a pull request! 🎉
Summary
This adds a user agent header to our installation of auto-installable extensions.
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)