fix: remove code supporting older versions of Node #6599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrstork
reviewed
Aug 6, 2025
| } catch (_error) { | ||
| try { | ||
| return resolvePathFollowSymlinks(`${moduleName}/package.json`, baseDirs) | ||
| } catch (error_) { |
There was a problem hiding this comment.
After your changes, we no longer need to catch the first error, and we can rename the second caught error now that there aren't two to manage:
Suggested change
| } catch (error_) { | |
| } catch { | |
| ... | |
| } catch (error) { | |
| return await resolvePackageFallback(..., error) |
mrstork
changed the title
mrstork
approved these changes
Aug 6, 2025
Closed
Merged
This was referenced Aug 11, 2025
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This resolves various Node.js version-related TODOs that are now safe to fix since the minimum supported Node.js version is 18.14.0.
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)