From 63dc1e823bc015e40d7c692d861eaf18038141e7 Mon Sep 17 00:00:00 2001 From: Mateusz Bocian Date: Fri, 6 Dec 2024 13:25:14 -0500 Subject: [PATCH 1/4] Update DENO_VERSION_RANGE --- packages/edge-bundler/node/bridge.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/edge-bundler/node/bridge.ts b/packages/edge-bundler/node/bridge.ts index 8405c60978..92ee0a8d48 100644 --- a/packages/edge-bundler/node/bridge.ts +++ b/packages/edge-bundler/node/bridge.ts @@ -12,12 +12,7 @@ import { getLogger, Logger } from './logger.js' import { getBinaryExtension } from './platform.js' const DENO_VERSION_FILE = 'version.txt' - -// When updating DENO_VERSION_RANGE, ensure that the deno version installed in the -// build-image/buildbot does satisfy this range! -// We're pinning the range because of an issue with v1.45.0 of the Deno CLI: -// https://linear.app/netlify/issue/FRP-775/deno-cli-v1450-causing-issues -const DENO_VERSION_RANGE = '1.37.0 - 1.44.4' +const DENO_VERSION_RANGE = '1.37.0 - 1.46.3' type OnBeforeDownloadHook = () => void | Promise type OnAfterDownloadHook = (error?: Error) => void | Promise From fa3cf897b1bb564f07ab3599f3e1512d62964859 Mon Sep 17 00:00:00 2001 From: Mateusz Bocian Date: Mon, 9 Dec 2024 14:01:56 -0500 Subject: [PATCH 2/4] chore: update lower end of deno version range --- packages/edge-bundler/node/bridge.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/edge-bundler/node/bridge.ts b/packages/edge-bundler/node/bridge.ts index 92ee0a8d48..aa5ab0d2bf 100644 --- a/packages/edge-bundler/node/bridge.ts +++ b/packages/edge-bundler/node/bridge.ts @@ -12,7 +12,7 @@ import { getLogger, Logger } from './logger.js' import { getBinaryExtension } from './platform.js' const DENO_VERSION_FILE = 'version.txt' -const DENO_VERSION_RANGE = '1.37.0 - 1.46.3' +const DENO_VERSION_RANGE = '1.39.0 - 1.46.3' type OnBeforeDownloadHook = () => void | Promise type OnAfterDownloadHook = (error?: Error) => void | Promise From a89a5b6b81f5c47d413fbb9d68462b5f1255500b Mon Sep 17 00:00:00 2001 From: Mateusz Bocian Date: Tue, 10 Dec 2024 12:58:06 -0500 Subject: [PATCH 3/4] test: match deno ranges in tests to DENO_VERSION_RANGE --- .github/workflows/workflow.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml index bc94a7a980..15d4f3abf0 100644 --- a/.github/workflows/workflow.yml +++ b/.github/workflows/workflow.yml @@ -52,11 +52,11 @@ jobs: os: [ubuntu-latest, macOS-latest, windows-latest] node-version: ['*'] # Must include the minimum deno version from the `DENO_VERSION_RANGE` constant in `node/bridge.ts`. - deno-version: ['v1.37.0', 'v1.44.4'] + deno-version: ['v1.39.0', 'v1.46.3'] include: - os: ubuntu-latest node-version: '14.16.0' - deno-version: 'v1.44.4' + deno-version: 'v1.46.3' fail-fast: false steps: # Increasing the maximum number of open files. See: @@ -192,7 +192,7 @@ jobs: - name: Setup Deno uses: denoland/setup-deno@v1 with: - deno-version: v1.44.4 + deno-version: v1.46.3 if: ${{ !steps.release-check.outputs.IS_RELEASE }} - name: Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4 From 17df558207802e47dfcf8187e349e29b10f0e3d6 Mon Sep 17 00:00:00 2001 From: Mateusz Bocian Date: Wed, 11 Dec 2024 12:17:44 -0500 Subject: [PATCH 4/4] fix: update comment with a link to buildbot --- packages/edge-bundler/node/bridge.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/edge-bundler/node/bridge.ts b/packages/edge-bundler/node/bridge.ts index aa5ab0d2bf..a597bd3275 100644 --- a/packages/edge-bundler/node/bridge.ts +++ b/packages/edge-bundler/node/bridge.ts @@ -12,6 +12,10 @@ import { getLogger, Logger } from './logger.js' import { getBinaryExtension } from './platform.js' const DENO_VERSION_FILE = 'version.txt' + +// When updating DENO_VERSION_RANGE, ensure that the deno version +// on the netlify/buildbot build image satisfies this range! +// https://github.com/netlify/buildbot/blob/f9c03c9dcb091d6570e9d0778381560d469e78ad/build-image/noble/Dockerfile#L410 const DENO_VERSION_RANGE = '1.39.0 - 1.46.3' type OnBeforeDownloadHook = () => void | Promise