fix(deps): update dependency lambda-local to v2.0.2 (#4443)

* fix(deps): update dependency lambda-local to v2.0.2

* chore: update contributors field

* feat: update to correctly mirror synchronous execution (closes #4304)

* chore: update contributors field

* chore: update contributors field

* fix: format

* chore: update contributors field

* chore: update contributors field

* fix: tests

* chore: update contributors field

* chore: update contributors field

* fix: another test

* chore: update contributors field

* fix: another test

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: Netlify Team Account 1 <[email protected]>
Co-authored-by: Skn0tt <[email protected]>
Co-authored-by: token-generator-app[bot] <token-generator-app[bot]@users.noreply.github.com>
Co-authored-by: Simon Knott <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Erez Rokah <[email protected]>

Author: 7 people

npm-shrinkwrap.json

@@ -110,6 +110,7 @@
     "Sergii Zinkevych",
     "Shawn Erquhart <[email protected]>",
     "Shawn Makinson (http://smakinson.github.io)",
+    "Simon Knott <[email protected]> (https://twitter.com/skn0tt)",
     "Souma Suzuki <[email protected]>",
     "Sébastien Chopin <[email protected]> (https://twitter.com/Atinux)",
     "Takumi Hirunuma <[email protected]> (https://twitter.com/mg111_)",

package.json

@@ -79,6 +79,11 @@ const validateLambdaResponse = (lambdaResponse) => {
   if (lambdaResponse === undefined) {
     return { error: 'lambda response was undefined. check your function code again' }
   }
+  if (lambdaResponse === null) {
+    return {
+      error: 'no lambda response. check your function code again. make sure to return a promise or use the callback.',
+    }
+  }
   if (!Number(lambdaResponse.statusCode)) {
     return {
       error: `Your function response must have a numerical statusCode. You gave: $ ${lambdaResponse.statusCode}`,

src/lib/functions/synchronous.js

@@ -625,7 +625,7 @@ test('should serve helpful tips and tricks', async (t) => {
         content: `
           const { schedule } = require('@netlify/functions')
 
-          module.exports.handler = schedule('@daily', () => {
+          module.exports.handler = schedule('@daily', async () => {
             return {
               statusCode: 200,
               body: "hello world"
@@ -684,7 +684,7 @@ test('should emulate next_run for scheduled functions', async (t) => {
         path: 'functions/hello-world.js',
         content: `
           const { schedule } = require('@netlify/functions')
-          module.exports.handler = schedule("@daily", (event) => {
+          module.exports.handler = schedule("@daily", async (event) => {
             const { next_run } = JSON.parse(event.body)
             return {
               statusCode: !!next_run ? 200 : 400,
@@ -748,7 +748,7 @@ test('should detect file changes to scheduled function', async (t) => {
       .withContentFile({
         path: 'functions/hello-world.js',
         content: `
-          module.exports.handler = () => {
+          module.exports.handler = async () => {
             return {
               statusCode: 200
             }
@@ -772,7 +772,7 @@ test('should detect file changes to scheduled function', async (t) => {
           content: `
           const { schedule } = require('@netlify/functions')
 
-          module.exports.handler = schedule("@daily", () => {
+          module.exports.handler = schedule("@daily", async () => {
             return {
               statusCode: 200,
               body: "test"

tests/integration/20.command.functions.test.js

@@ -510,7 +510,7 @@ testMatrix.forEach(({ args }) => {
           path: 'functions/hello/index.js',
           content: `
 const response = require("./dist")
-exports.handler = () => ({
+exports.handler = async () => ({
   statusCode: 200,
   body: response
 })`,

tests/integration/330.serving-functions.test.js

@@ -137,6 +137,26 @@ testMatrix.forEach(({ args }) => {
     })
   })
 
+  test(testName('should replicate Lambda behaviour for synchronous return values', args), async (t) => {
+    await withSiteBuilder('site-replicate-aws-sync-behaviour', async (builder) => {
+      builder.withNetlifyToml({ config: { functions: { directory: 'functions' } } }).withFunction({
+        path: 'env.js',
+        handler: () => ({
+          statusCode: 200,
+        }),
+      })
+
+      await builder.buildAsync()
+
+      await withDevServer({ cwd: builder.directory, args }, async (server) => {
+        const response = await got(`${server.url}/.netlify/functions/env`, {
+          throwHttpErrors: false,
+        })
+        t.true(response.body.startsWith('no lambda response.'))
+      })
+    })
+  })
+
   test(testName('should redirect using a wildcard when set in netlify.toml', args), async (t) => {
     await withSiteBuilder('site-with-redirect-function', async (builder) => {
       builder

tests/integration/400.command.dev.test.js

@@ -18,7 +18,7 @@ test.before(async () => {
   mkdirSync(functionsDirectory)
 
   const mainFile = join(functionsDirectory, 'hello.js')
-  writeFileSync(mainFile, `exports.handler = (event) => ({ statusCode: 200, body: event.rawUrl })`)
+  writeFileSync(mainFile, `exports.handler = async (event) => ({ statusCode: 200, body: event.rawUrl })`)
 
   const functionsRegistry = new FunctionsRegistry({
     projectRoot,