-
Notifications
You must be signed in to change notification settings - Fork 402
refactor: use async fs calls in src/utils/proxy.js #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If you don't mind, I want to challenge to fix this issue ! |
Thanks @mugi111, I assigned you to the issue. Please let me know if there is anything you need. |
Line 235 in 5c9fed7
Let me ask for advice on how to fix this. Is it correct to filter the headersFiles with fs.stat() and isFiles() once and then use map() for that array?
|
You could use https://github.com/sindresorhus/p-filter to filter promises, then run Line 18 in 5c9fed7
|
Thank you. It was helpful. |
This issue looks like solved, why still opened ? |
Yes, this is solved, thanks for raising this @iChenLei 👍 |
Describe the bug
This file could easily use the async versions of the fs functions instead of the sync ones.
Additional context
See: #1271 (comment)
The text was updated successfully, but these errors were encountered: