Skip to content

fix: use pagination API when listing sites #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erezrokah opened this issue Feb 17, 2021 · 0 comments · Fixed by #1899
Closed

fix: use pagination API when listing sites #1898

erezrokah opened this issue Feb 17, 2021 · 0 comments · Fixed by #1899
Assignees
@erezrokah
Labels
area: command: link area: command: sites type: bug code to address defects in shipped code

Comments

@erezrokah
Copy link
Contributor

Related to #258, netlify/js-client#39, netlify/js-client#285 and netlify/js-client#287.

js-client now supports pagination parameters (though not returning headers yet). We should pass those when calling listSites to make sure we retrieve all results.
@erezrokah erezrokah added type: feature code contributing to the implementation of a feature and/or user facing functionality type: bug code to address defects in shipped code area: command: link area: command: sites and removed type: feature code contributing to the implementation of a feature and/or user facing functionality labels Feb 17, 2021
@erezrokah erezrokah self-assigned this Feb 17, 2021
@erezrokah erezrokah mentioned this issue Feb 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erezrokah erezrokah

Labels
area: command: link area: command: sites type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(command-link): retrieve all sites using pagination params netlify/cli
1 participant
@erezrokah