Docker Utilization Disabled on Windows (#1459)

* Disable docker utilization on Windows by default

* Fix testing issue

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Author: TimPansino

newrelic/core/agent_protocol.py

@@ -14,6 +14,7 @@
 
 import logging
 import os
+import sys
 from pathlib import Path
 
 from newrelic import version
@@ -355,9 +356,16 @@ def _connect_payload(app_name, linked_applications, environment, settings):
 
         if settings["utilization.detect_docker"]:
             if not ecs_id:
-                docker = DockerUtilization.detect()
-                if docker:
-                    utilization_vendor_settings["docker"] = docker
+                if sys.platform == "win32":
+                    _logger.warning(
+                        "Docker utilization detection is not supported on Windows. "
+                        "Skipping Docker utilization detection. You can disable this "
+                        "warning by not setting utilization.detect_docker in your configuration."
+                    )
+                else:
+                    docker = DockerUtilization.detect()
+                    if docker:
+                        utilization_vendor_settings["docker"] = docker
 
         if settings["utilization.detect_kubernetes"]:
             kubernetes = KubernetesUtilization.detect()

newrelic/core/config.py

@@ -27,6 +27,7 @@
 import logging
 import os
 import re
+import sys
 import threading
 import urllib.parse as urlparse
 
@@ -960,7 +961,7 @@ def default_otlp_host(host):
 _settings.utilization.detect_aws = True
 _settings.utilization.detect_azure = True
 _settings.utilization.detect_azurefunction = True
-_settings.utilization.detect_docker = True
+_settings.utilization.detect_docker = sys.platform != "win32"  # Docker detection is not supported on Windows
 _settings.utilization.detect_kubernetes = True
 _settings.utilization.detect_gcp = True
 _settings.utilization.detect_pcf = True

tests/agent_unittests/test_agent_protocol.py

@@ -15,6 +15,7 @@
 import logging
 import os
 import ssl
+import sys
 import tempfile
 from pathlib import Path
 
@@ -375,6 +376,12 @@ def test_connect(
     with_aws, with_ecs, with_pcf, with_gcp, with_azure, with_azurefunction, with_docker, with_kubernetes, with_ip
 ):
     global AWS, AZURE, AZUREFUNCTION, GCP, PCF, DOCKER, KUBERNETES, IP_ADDRESS
+
+    if sys.platform == "win32":
+        # Docker utilization is not supported on Windows.
+        # Override the test matrix to always be False.
+        with_docker = False
+
     if not with_aws:
         AWS = Exception
     if not with_pcf: