-
Notifications
You must be signed in to change notification settings - Fork 138
Better display of code blocks #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
You're right, but unfortunately, your fix breaks inline code formatting (i.e. |
Now just figure out the whitespace :) EDIT: Specified selector to not need |
Nice! Thank you very much, that's so cool! I will integrate this in the next release 🎉 |
Do not include that code yet! It renders weird on my system unless I also have the following:
Any one else see this issue? If I don't have that, the line-height of the Only bug I see is that if you select text within a line of the code block, that line becomes white again. I haven't figured out a way to solve this issue yet. New lines within a code block will also still be white, as described by the OP. Haven't figured that out yet either... CodeMirror spits out some really unhelpful elements and styles into the page. |
There is a problem with the Anyone got a better workaround for the vertical spacing issue? |
Due to #290, we have huge changes in the editor. It looks to me, that the following code has no side-effects, any more:
Could you please test this again with the current code base, @tnyeanderson ? |
Uh oh!
There was an error while loading. Please reload this page.
Code blocks are not displayed correctly. The grey background just ends after the last character and there is some space between the lines. Giving the
.CodeMirror .CodeMirror-code .cm-comment
Element the attributedisplay: block;
would enhance the way it shows.Then newlines in between just would need to get the right css-class and the way it looks would be great.
Now: https://imgur.com/N0clBhZ
After: https://imgur.com/RNvaahl
The text was updated successfully, but these errors were encountered: