Add linting to Arcgis plugin - Service (#240)

* Convert httpClient calls to @esri/arcgis-rest-request with ArcGISIdentityManager for authentication

* Fix addFields and deleteFields

* Fixed outFields and returnGeometry for query generation

* [service] prepend form name to all event form fields for clarity and to avoid ESRI column name conflicts

* [service] Fix check to determine if an observation sync to ESRI is a create or update

* [service] OAuth refresh token flow in work

* [service] Add IdentityManager to ObservationSender construction

* [service] Remove httpClient

* [service] fix FeatureQuerier response from request

* [service] Refactor ArcGISIdentityManager management

* draft changes

* [service] ArcGIS field names are lowercase, account for this when adding/removing fields

* Undo revert of FeatureQuerier

* [service] Remove HttpClient.ts, no longer used

* [service] updateConfig inner async methods await before we query

* [server] Attribute sync fix upon adding feature server

* [web/service] API update to include feature service authentication status

* [service] fix regression in token, username/password validation req parameter parsing

* [service] Clean up TODO comments

* [service] form field mapping need to account for form name and field name to avoid conflicts

* Reduce response logging that may cause confusion

* [service] include event forms in detecting config changes

* Merge develop

* [service] sync configured events instead of checking changes of all events. Store event ids instead of names

* [server] Fix query syntax error

* fix failing errors for observations

* [service] fix event deletion and firstRun logic

* fix issues with updates

* fix deletion issue

* init

* add lint to services

* fix required field issue

* update arcgis read me

---------

Co-authored-by: Rick Saccoccia <[email protected]>
Co-authored-by: William Newman <[email protected]>
Co-authored-by: Clinton Werth <[email protected]>

Author: 4 people

plugins/arcgis/service/eslint.config.mjs

@@ -0,0 +1,27 @@
+import pluginJs from "@eslint/js";
+import tseslint from "typescript-eslint";
+import jsdoc from 'eslint-plugin-jsdoc';
+
+/** @type {import('eslint').Linter.Config[]} */
+export default [
+  {
+    files: ["**/*.{js,mjs,cjs,ts}"],
+    plugins: { jsdoc },
+    rules: {
+      "jsdoc/require-description": "warn",
+      "semi": ["error", "always"]
+    },
+    "overrides": [
+      {
+        // enable the rule specifically for TypeScript files
+        "files": ["*.ts", "*.tsx"],
+        "rules": {
+          "@typescript-eslint/no-explicit-any": "off"
+        }
+      }
+    ]
+  },
+  pluginJs.configs.recommended,
+  ...tseslint.configs.recommended,
+  jsdoc.configs['flat/recommended'],
+];