Skip to content

Commit f44b06a

Browse files
authored
Merge pull request #409 from nginx-proxy/docker-gen-version-env
Set DOCKER_GEN_VERSION in Docker image env
2 parents a84a51d + 8b72f3a commit f44b06a

File tree

3 files changed

+16
-9
lines changed

3 files changed

+16
-9
lines changed

.github/workflows/dockerhub.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ jobs:
9494
uses: docker/build-push-action@v2
9595
with:
9696
context: .
97-
build-args: VERSION=${{ env.GIT_DESCRIBE }}
97+
build-args: DOCKER_GEN_VERSION=${{ env.GIT_DESCRIBE }}
9898
platforms: linux/amd64,linux/arm64,linux/arm/v7
9999
push: true
100100
tags: ${{ steps.docker_meta_alpine.outputs.tags }}
@@ -106,7 +106,7 @@ jobs:
106106
uses: docker/build-push-action@v2
107107
with:
108108
context: .
109-
build-args: VERSION=${{ env.GIT_DESCRIBE }}
109+
build-args: DOCKER_GEN_VERSION=${{ env.GIT_DESCRIBE }}
110110
file: Dockerfile.debian
111111
platforms: linux/amd64,linux/arm64,linux/arm/v7
112112
push: true

Dockerfile

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,23 @@
1+
ARG DOCKER_GEN_VERSION=main
2+
13
# Build docker-gen from scratch
24
FROM golang:1.17.8-alpine as go-builder
35

4-
ARG VERSION=main
5-
6+
ARG DOCKER_GEN_VERSION
67
WORKDIR /build
78

89
# Install the dependencies
910
COPY . .
1011
RUN go mod download
1112

1213
# Build the docker-gen executable
13-
RUN GOOS=linux CGO_ENABLED=0 go build -ldflags "-X main.buildVersion=${VERSION}" -o docker-gen ./cmd/docker-gen
14+
RUN GOOS=linux CGO_ENABLED=0 go build -ldflags "-X main.buildVersion=${DOCKER_GEN_VERSION}" -o docker-gen ./cmd/docker-gen
1415

1516
FROM alpine:3.15.0
1617

17-
ENV DOCKER_HOST unix:///tmp/docker.sock
18+
ARG DOCKER_GEN_VERSION
19+
ENV DOCKER_GEN_VERSION=${DOCKER_GEN_VERSION} \
20+
DOCKER_HOST=unix:///tmp/docker.sock
1821

1922
# Install packages required by the image
2023
RUN apk add --no-cache --virtual .bin-deps openssl

Dockerfile.debian

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1+
ARG DOCKER_GEN_VERSION=main
2+
13
# Build docker-gen from scratch
24
FROM golang:1.17.8 as go-builder
35

4-
ARG VERSION=main
6+
ARG DOCKER_GEN_VERSION
57

68
WORKDIR /build
79

@@ -10,11 +12,13 @@ COPY . .
1012
RUN go mod download
1113

1214
# Build the docker-gen executable
13-
RUN GOOS=linux go build -ldflags "-X main.buildVersion=${VERSION}" -o docker-gen ./cmd/docker-gen
15+
RUN GOOS=linux go build -ldflags "-X main.buildVersion=${DOCKER_GEN_VERSION}" -o docker-gen ./cmd/docker-gen
1416

1517
FROM debian:11.2-slim
1618

17-
ENV DOCKER_HOST unix:///tmp/docker.sock
19+
ARG VERSION
20+
ENV DOCKER_GEN_VERSION=${VERSION} \
21+
DOCKER_HOST=unix:///tmp/docker.sock
1822

1923
# Install packages required by the image
2024
RUN apt-get update \

0 commit comments

Comments
 (0)