[Impeller] Don't enable KHR_debug on Angle. (flutter/engine#56601)

chinmaygarde · web-flow · commit 1c9aa9544ffa · 2024-11-15T01:33:32.000Z
All it does it log the calls and overwhelms the output for no utility. <img width="651" alt="Screenshot 2024-11-14 at 3 53 54â�¯PM" src="https://github.com/user-attachments/assets/b2de0d71-6263-4f00-94a0-73a5c0d0135d">
diff --git a/engine/src/flutter/impeller/renderer/backend/gles/description_gles.cc b/engine/src/flutter/impeller/renderer/backend/gles/description_gles.cc
@@ -178,7 +178,10 @@ bool DescriptionGLES::HasExtension(const std::string& ext) const {
 }
 
 bool DescriptionGLES::HasDebugExtension() const {
-  return HasExtension("GL_KHR_debug");
+  // Angle just logs calls instead of forwarding debug information to the
+  // backend. This just overwhelms the logs and is of limited use. Disable on
+  // Angle.
+  return HasExtension("GL_KHR_debug") && !IsANGLE();
 }
 
 }  // namespace impeller

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,10 @@ bool DescriptionGLES::HasExtension(const std::string& ext) const {`
`178`	`178`	`}`
`179`	`179`
`180`	`180`	`bool DescriptionGLES::HasDebugExtension() const {`
`181`		`- return HasExtension("GL_KHR_debug");`
	`181`	`+ // Angle just logs calls instead of forwarding debug information to the`
	`182`	`+ // backend. This just overwhelms the logs and is of limited use. Disable on`
	`183`	`+ // Angle.`
	`184`	`+ return HasExtension("GL_KHR_debug") && !IsANGLE();`
`182`	`185`	`}`
`183`	`186`
`184`	`187`	`} // namespace impeller`