[Impeller] enable OpenGL fallback on Android. (flutter/engine#56591)

jonahwilliams · web-flow · commit d0cf81dfe08d · 2024-11-15T16:48:05.000Z
Ship impeller OpenGLES on non-vulkan android devices Fixes flutter#158361
diff --git a/engine/src/flutter/shell/platform/android/flutter_main.cc b/engine/src/flutter/shell/platform/android/flutter_main.cc
@@ -240,7 +240,7 @@ AndroidRenderingAPI FlutterMain::SelectedRenderingAPI(
     return AndroidRenderingAPI::kSoftware;
   }
   constexpr AndroidRenderingAPI kVulkanUnsupportedFallback =
-      AndroidRenderingAPI::kSkiaOpenGLES;
+      AndroidRenderingAPI::kImpellerOpenGLES;
 
   // Debug/Profile only functionality for testing a specific
   // backend configuration.
diff --git a/engine/src/flutter/shell/platform/android/platform_view_android_unittests.cc b/engine/src/flutter/shell/platform/android/platform_view_android_unittests.cc
@@ -22,7 +22,7 @@ TEST(AndroidPlatformView, SelectsVulkanBasedOnApiLevel) {
               AndroidRenderingAPI::kImpellerVulkan);
   } else {
     EXPECT_EQ(FlutterMain::SelectedRenderingAPI(settings),
-              AndroidRenderingAPI::kSkiaOpenGLES);
+              AndroidRenderingAPI::kImpellerOpenGLES);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ AndroidRenderingAPI FlutterMain::SelectedRenderingAPI(`
`240`	`240`	`return AndroidRenderingAPI::kSoftware;`
`241`	`241`	`}`
`242`	`242`	`constexpr AndroidRenderingAPI kVulkanUnsupportedFallback =`
`243`		`- AndroidRenderingAPI::kSkiaOpenGLES;`
	`243`	`+ AndroidRenderingAPI::kImpellerOpenGLES;`
`244`	`244`
`245`	`245`	`// Debug/Profile only functionality for testing a specific`
`246`	`246`	`// backend configuration.`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ TEST(AndroidPlatformView, SelectsVulkanBasedOnApiLevel) {`
`22`	`22`	`AndroidRenderingAPI::kImpellerVulkan);`
`23`	`23`	`} else {`
`24`	`24`	`EXPECT_EQ(FlutterMain::SelectedRenderingAPI(settings),`
`25`		`- AndroidRenderingAPI::kSkiaOpenGLES);`
	`25`	`+ AndroidRenderingAPI::kImpellerOpenGLES);`
`26`	`26`	`}`
`27`	`27`	`}`
`28`	`28`