-
Notifications
You must be signed in to change notification settings - Fork 532
Do user-defined interfaces need TraitedSpec
classes?
#2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@mwaskom - it's so that we can derive classes and functionality. also the dict formulation won't support all the functionality that is basetraitedspec and traitedspec. that being said we will revisit this in both our current push to traitlets and with API v2. |
@satra I understand why it's useful to have them in nipype, my question is whether it's possible to let users specify dictionaries of inputs/outputs and have nipype create the TraitedSpec objects and inject the traits internally, to save users from writing unnecessary boilerplate. I've found that given the limitations of the |
@mwaskom - that's a fair point. i think we should rethink the user oriented design of nipype and minimize boilerplate where possible. |
👍👍👍👍👍 |
I'll try to take a stab at this. No promises, though. |
See #2083 -- not battle-tested yet, but it was straightforward to implement a proof of principle. |
Uh oh!
There was an error while loading. Please reload this page.
There is a lot of boilerplate required to define an interface. From the docs a "simple" example of a custom Interface requires defining three classes:
Is there a technical reason why the user has to define the input and output specs as classes, rather than let the user define dictionaries of inputs and output traits and have nipype define the classes internally? i.e.
The text was updated successfully, but these errors were encountered: