napi: fix implementation of napi_create_boolean

Gabriel Schulhof · Gabriel Schulhof · commit e2480ba99886 · 2017-01-16T10:53:57.000+02:00
Need to call JsBoolToBoolean(), not JsDoubleToNumber() when creating a JS boolean from a bool. Closes: #31
diff --git a/src/node_jsrtapi.cc b/src/node_jsrtapi.cc
@@ -501,7 +501,7 @@ napi_value napi_create_number(napi_env e, double v) {
 napi_value napi_create_boolean(napi_env e, bool b) {
   JsErrorCode error = JsNoError;
   JsValueRef booleanValue = nullptr;
-  error = JsDoubleToNumber(b, &booleanValue);
+  error = JsBoolToBoolean(b, &booleanValue);
   return reinterpret_cast<napi_value>(booleanValue);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -501,7 +501,7 @@ napi_value napi_create_number(napi_env e, double v) {`
`501`	`501`	`napi_value napi_create_boolean(napi_env e, bool b) {`
`502`	`502`	`JsErrorCode error = JsNoError;`
`503`	`503`	`JsValueRef booleanValue = nullptr;`
`504`		`- error = JsDoubleToNumber(b, &booleanValue);`
	`504`	`+ error = JsBoolToBoolean(b, &booleanValue);`
`505`	`505`	`return reinterpret_cast<napi_value>(booleanValue);`
`506`	`506`	`}`
`507`	`507`