-
-
Notifications
You must be signed in to change notification settings - Fork 170
Give @shigeki access to linuxOne machine for openSSL work #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1 |
+1 |
1 similar comment
+1 |
Is this still required now nodejs/node#19944 has been closed? |
If it allowed, I'd like to have an access it in order to check if OpenSSL-1.1.0 built with Node is properly by comparing those built from the OpenSSL sources. I also need to submit a patch for S390 of nodejs/node@1bcb6c0 to the upstream but I never checked it on that machine except CI jobs of Node. |
Aside: Looks like we may need to update the ansible stuff so that the ssh config writing playbook writes info for |
@shigeki I've added your public keys to test-linuxonecc-rhel72-s390x-2. Let me know if the work you're doing requires us to take it out of the CI rotation. When you're done, leave a comment here and I'll remove your keys (or remove them yourself) and close this issue. |
@Trott Thanks. I can login the machine and make test builds of openssl and node in |
@Trott good point on -3, I added those as one to test the new compiler changes, I'll figure out if I'm going to remove from the CI or add to ansible. |
@shigeki is your access still required here? |
Removed access from |
Thanks. I've confirmed that it's no problem. |
See: nodejs/node#19944 (comment)
@shigeki is a long standing Node.js collaborator and past TSC member
The text was updated successfully, but these errors were encountered: