Skip to content

Give @shigeki access to linuxOne machine for openSSL work #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson opened this issue Apr 20, 2018 · 12 comments
Closed

Give @shigeki access to linuxOne machine for openSSL work #1246

mhdawson opened this issue Apr 20, 2018 · 12 comments

Comments

@mhdawson
Copy link
Member

See: nodejs/node#19944 (comment)

@shigeki is a long standing Node.js collaborator and past TSC member

@mhdawson
Copy link
Member Author

+1
@nodejs/build

@Trott
Copy link
Member

Trott commented Apr 20, 2018

+1

1 similar comment
@gibfahn
Copy link
Member

gibfahn commented Apr 22, 2018

+1

@richardlau
Copy link
Member

Is this still required now nodejs/node#19944 has been closed?

@shigeki
Copy link

shigeki commented Apr 23, 2018

If it allowed, I'd like to have an access it in order to check if OpenSSL-1.1.0 built with Node is properly by comparing those built from the OpenSSL sources. I also need to submit a patch for S390 of nodejs/node@1bcb6c0 to the upstream but I never checked it on that machine except CI jobs of Node.
https://github.com/shigeki.keys are my public keys.

@Trott
Copy link
Member

Trott commented Apr 23, 2018

Aside: Looks like we may need to update the ansible stuff so that the ssh config writing playbook writes info for test-linuxonecc-rhel72-s390x-3? I'm only getting -1 and -2.

@Trott
Copy link
Member

Trott commented Apr 23, 2018

@shigeki I've added your public keys to test-linuxonecc-rhel72-s390x-2. Let me know if the work you're doing requires us to take it out of the CI rotation. When you're done, leave a comment here and I'll remove your keys (or remove them yourself) and close this issue.

@shigeki
Copy link

shigeki commented Apr 24, 2018

@Trott Thanks. I can login the machine and make test builds of openssl and node in /data/shigeki. Build binaries were already transferred to my local machine but they are not yet checked. And checking my openssl PR is not yet done, too. Please keep my access for a while. I will ask you to remove my access after my all tasks finished. Thanks, again.

@mhdawson
Copy link
Member Author

@Trott good point on -3, I added those as one to test the new compiler changes, I'll figure out if I'm going to remove from the CI or add to ansible.

@gdams
Copy link
Member

gdams commented May 30, 2018

@shigeki is your access still required here?

@maclover7
Copy link
Contributor

Removed access from test-linuxonecc-rhel72-s390x-2, easy enough to add back later if still needed

@shigeki
Copy link

shigeki commented Jun 3, 2018

Thanks. I've confirmed that it's no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants