Skip to content

jenkins: ping users #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack opened this issue Jun 2, 2017 · 10 comments
Closed

jenkins: ping users #746

refack opened this issue Jun 2, 2017 · 10 comments

Comments

@refack
Copy link
Contributor

refack commented Jun 2, 2017

It would be nice if Jenkins would ping (i.e. e-mail) users, on job completion.
A possible list:

  1. The user who started the job
  2. For PRs the OP (or tell the bot to add a comment)
  3. [future] for breakage on master all commit authors since last green

Since jobs take some time and some of us are a bit ADHD ( :shipit: me ⚡️ ) with melignent tabitis

image
yes that's 68 open tabs, and that's only my node window

Sometimes I forget to follow up on jobs.

@rvagg
Copy link
Member

rvagg commented Jun 9, 2017

We could add an optional email field in the build request page, since we have email infra working now and the IBM boys seem to be successfully using it post-build, perhaps it wouldn't be hard to add.

@refack
Copy link
Contributor Author

refack commented Jun 9, 2017

I would be very appreciative 😍

@gibfahn
Copy link
Member

gibfahn commented Jun 9, 2017

I'd much rather not have emails on Job completion, I guess it'd be okay if it was opt-in (maybe another checkbox in node-test-pull-request).

I just go through the PRs that I raised and the ones I've self-assigned and check for any updates.

We're using the email notifications to signal that something's wrong with the IBM machines.

If we get to the point where the github bot is running PRs for us then the bot could edit its comment with the result of the build once it finishes. Do edited comments trigger another email notification?

@mcollina
Copy link
Member

mcollina commented Jun 9, 2017

I'm 👍 on receiving an email field, and if you want to be notified you can just past your email there.
I'm 👎 on automatic emails.

@gibfahn editing comments do not trigger an email notification. I'd prefer a direct email than a comment in a gh pr.

@mhdawson
Copy link
Member

mhdawson commented Jun 9, 2017

An optional email field seems like a good idea to me. If we get consensus I can take a look at doing that. As long as we can use dynamic elements in the list of emails notifications get sent to it might be pretty easy.

@cjihrig
Copy link
Contributor

cjihrig commented Jun 9, 2017

I'm +1 on being able to opt in to getting an email on job completion.

@refack
Copy link
Contributor Author

refack commented Jun 9, 2017

Opt in is great 💯

@refack
Copy link
Contributor Author

refack commented Jun 9, 2017

Do edited comments trigger another email notification?

Only if the edit has a new mention.

@mmarchini
Copy link
Contributor

I like the optional e-mail idea. We could also have an optional webhook (if someone wants to get notified through Slack, for example).

Does Jenkins have the option to create custom fields for users? If so, we could let each user set up their preferred default behavior.

@sam-github
Copy link
Contributor

Closing as stale, but if anyone wants to take this up feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants